Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test: fix TestAgentConnectionMonitor_PingTimeout race with mock assertions#19836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/internal-970-ping-timout-flake
Sep 16, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 16, 2025•
edited
Loading

Fixescoder/internal#970

The test doesn't wait formonitor() to complete, and the mock database call that we assert takes place in adefer withinmonitor(). This allows the mock assertions to race with the defer and flake the test.

Solution is to explicitly wait formonitor() to complete before the end of the test, so that mock assertions (which happen in at.Cleanup()) don't race.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis requested review frommafredri andethanndickson and removed request formafredriSeptember 16, 2025 11:50
@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 16, 2025 11:50
@ethanndickson
Copy link
Member

ethanndickson commentedSep 16, 2025•
edited
Loading

fwiw, I've recently tended towards usingtest: for my flake fix prs. The bot accepts it (pr-title, notpr-title/grammar) and it makes Kirby's life a bit easier when he's doing the changelog (though in this case it's very much obvious this is a test flake fix!)

@spikecurtisspikecurtis changed the titlefix: fix TestAgentConnectionMonitor_PingTimeout race with mock assertionstest: fix TestAgentConnectionMonitor_PingTimeout race with mock assertionsSep 16, 2025
@spikecurtisspikecurtis merged commit655a36c intomainSep 16, 2025
39 of 40 checks passed
@spikecurtisspikecurtis deleted the spike/internal-970-ping-timout-flake branchSeptember 16, 2025 17:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestAgentConnectionMonitor_PingTimeout
2 participants
@spikecurtis@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp