NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

fix: trim whitespace from API tokens#19814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ThomasK33 merged 1 commit intomainfromthomask33/09-12-test_httpmw_deflake_rfc6750_bearer_token_tests_on_windows

Sep 15, 2025

Merged

fix: trim whitespace from API tokens#19814

ThomasK33 merged 1 commit intomainfromthomask33/09-12-test_httpmw_deflake_rfc6750_bearer_token_tests_on_windows

Sep 15, 2025

Conversation

Copy link

Member

ThomasK33 commentedSep 15, 2025•
edited
Loading

Trim whitespace from API tokens in Authorization headers and query parameters

This PR enhances the API token extraction logic by trimming whitespace from tokens obtained via:

Authorization: Bearer headers
access_token query parameters

The change ensures consistent token handling when tokens contain leading or trailing whitespace, improving authentication reliability.

The PR also removes unnecessaryt.Parallel() calls from OAuth2 bearer token tests to prevent potential race conditions during test execution.

Fixes:coder/internal#967

test(httpmw): deflake RFC6750 bearer token tests on Windows

5290532

Fixes flake where subtests used t.Parallel() while sharing a DB from dbtestutil.NewDB(t). On Windows, the parent test’s t.Cleanup closed the DB before parallel subtests finished, yielding intermittent 401 Unauthorized instead of 200. Serializing the subtests keeps the DB alive for each case and removes the flake.Also trims whitespace from Authorization: Bearer and access_token token extraction for robustness; no change to precedence or overall behavior.Change-Id: Ifa9ad5bb297dc96612dbfb9ef8bb0e16d8ce5778Signed-off-by: Thomas Kosiewski <tk@coder.com>