This PR adds a readiness wait to OAuth2 metadata endpoint tests to avoid rare races with server startup. Instead of immediately making HTTP requests, the tests now usetestutil.Eventually to retry the requests until they succeed, with a short interval between attempts. This helps prevent flaky tests that might fail due to timing issues during server initialization.

Fixes:coder/internal#996

github-actionsbot assignedThomasK33

Sep 15, 2025

Copy link

MemberAuthor

ThomasK33 commentedSep 15, 2025

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

ThomasK33 force-pushed thethomask33/09-12-test_oauth2provider_deflake_oauth2_metadata_tests_with_readiness_wait branch from652ebde to0f8cad1Compare

September 15, 2025 07:55

ThomasK33 marked this pull request as ready for review

September 15, 2025 07:57

ThomasK33 requested a review fromjohnstcn

September 15, 2025 08:01

johnstcn approved these changes

Sep 16, 2025

View reviewed changes

coderd/oauth2provider/metadata_test.go OutdatedShow resolvedHide resolved

test(oauth2provider): deflake OAuth2 metadata tests with readiness wait

1312cd9

Fix flake in TestOAuth2AuthorizationServerMetadata by polling the .well-known endpoints until they return 200 and valid JSON, using testutil.Eventually.Root cause: the test server can accept requests before the real handler is installed in coderdtest, returning 200 with an empty body which causes JSON decode EOF. The readiness loop avoids this race without sleeps and holds under t.Parallel().This fixes the following issue:coder/internal#996Change-Id: I466815d35f03bb75ef448d6f3431cd4b6efe2570Signed-off-by: Thomas Kosiewski <tk@coder.com>

ThomasK33 force-pushed thethomask33/09-12-test_oauth2provider_deflake_oauth2_metadata_tests_with_readiness_wait branch from0f8cad1 to1312cd9Compare

September 22, 2025 16:15

ThomasK33 merged commit6fb4cc6 intomain

Sep 22, 2025

32 checks passed