NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

fix: use filepath to construct mcp test write path#19808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

code-asher merged 1 commit intomainfromasher/mcp-write-abspath

Sep 15, 2025

Merged

fix: use filepath to construct mcp test write path#19808

code-asher merged 1 commit intomainfromasher/mcp-write-abspath

Sep 15, 2025

Conversation

Copy link

Member

code-asher commentedSep 12, 2025•
edited
Loading

Hopefullyfixescoder/internal#993

  file path must be absolute: "/test/some/path"

Not sure if this is the right fix though, since I am not sure how this only flakes rather than always failing. It looks like starting with/ should not be considered absolute in Windows, but then how did it ever pass at all?

fix: use filepath to construct mcp test write path

a3171ad

Hopefully fixes the test flake:  file path must be absolute: "/test/some/path"In Windows, starting with `/` is not considered absolute.  No idea howthis only flakes rather than always failing though.