Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): allow starting task workspace from task page#19790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 11 commits intomainfromdanielle/tasks/start-workspace
Sep 23, 2025

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedSep 12, 2025•
edited
Loading

Closes#19622

When viewing a task with a stopped workspace, instead show a 'Start workspace' button instead of a 'View workspace'. The user can still view the workspace by clicking the workspace button at the top right of the page.

2025-09-12.12-17-37.mov

@DanielleMaywoodDanielleMaywoodforce-pushed thedanielle/tasks/start-workspace branch 6 times, most recently froma6c6692 toa94feadCompareSeptember 12, 2025 10:57
@DanielleMaywoodDanielleMaywoodforce-pushed thedanielle/tasks/start-workspace branch froma94fead to9104badCompareSeptember 12, 2025 11:36
@DanielleMaywoodDanielleMaywood removed the request for review fromParkreinerSeptember 12, 2025 11:40
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! May be no harm to have a second pair of eyes from FE.

DanielleMaywood reacted with thumbs up emoji
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! I just left a few comments, but nothing blocking.

disabled={isMutationRunning}
onClick={()=>{
mutateStartWorkspace.mutate({
buildParameters:parameters?.buildParameters,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch—I probably would have overlooked that.

@BrunoQuaresma
Copy link
Collaborator

Also, don’t forget to review and approve the Chromatic tests.

open={apiError!==undefined}
error={apiError}
onClose={mutateStartWorkspace.reset}
showDetail={task.workspace.template_use_classic_parameter_flow}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is suspicious. why are we not showing details for dynamic parameters? it's the blessed path now

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just copied the other two instances of this and they both do that, I'm happy to update this though

@DanielleMaywoodDanielleMaywood merged commitb71d671 intomainSep 23, 2025
32 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/tasks/start-workspace branchSeptember 23, 2025 08:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac left review comments

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tasks: when workspace is stopped, CTA should say "start workspace"
4 participants
@DanielleMaywood@BrunoQuaresma@aslilac@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp