Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(site): display warnings in tasks page when wildcard is not configured#19780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

kacpersaw
Copy link
Contributor

@kacpersawkacpersaw commentedSep 11, 2025•
edited
Loading

Closes#19739

This PR adds warnings to Task page to alert users when wildcard is not configured.

Admin:
image

Member:
image

@kacpersawkacpersaw marked this pull request as ready for reviewSeptember 15, 2025 08:32
@matifali
Copy link
Member

How do the apps on the right behave if they require subdomain and wildcard access URL isn't configured?

@kacpersaw
Copy link
ContributorAuthor

kacpersaw commentedSep 15, 2025•
edited
Loading

How do the apps on the right behave if they require subdomain and wildcard access URL isn't configured?

@matifali Right now the warning only shows on the left. I can add it on the right too, but not sure how that would affect the UX. What do you think?

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code changes look good to me!

@matifali
Copy link
Member

matifali commentedSep 16, 2025•
edited
Loading

How do the apps on the right behave if they require subdomain and wildcard access URL isn't configured?

@matifali Right now the warning only shows on the left. I can add it on the right too, but not sure how that would affect the UX. What do you think?

@kacpersaw The warning should be displayed everywhere in our UI for anycoder_app that usessubdomain = true, and does not have a wildcard access URL configured. I think it will improve the UX because users will understand why the app isn't loading.

@kacpersawkacpersaw changed the titlefeat(site): display warning message when wildcard is not configured in task sidebarfeat(site): display warnings in tasks page when wildcard is not configuredSep 16, 2025
Copy link
Member

@ParkreinerParkreiner left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes still look good. The only thing I guess I'm a tiny bit worried about is the styling for the heading. Are we using these styles for headers elsewhere in the app already? Just want to make sure things stay consistent

@kacpersawkacpersaw merged commit0601cc8 intomainSep 19, 2025
34 checks passed
@kacpersawkacpersaw deleted the kacpersaw/feat-wildcard-access-url-warning-tasks-ui branchSeptember 19, 2025 13:49
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac left review comments

@matifalimatifaliAwaiting requested review from matifali

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

Assignees

@kacpersawkacpersaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add warning message to tasks UI
4 participants
@kacpersaw@matifali@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp