Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Avoid use of r.Context() after r.Hijack()#1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 6 commits intomainfrommafredri/fix-goroutine-leak
Jun 3, 2022

Conversation

mafredri
Copy link
Member

This PR changes how we initializewebsocket.NetConns so that we have a context that emits connection closure.

Fixes#1508

  • fix: Fix goroutine leak by propagating websocket closure
  • fix: Use of r.Context() in workspaceAgentDial
  • fix: Use of rw and r.Context() in workspaceAgentListen
  • fix: Use of r.Context() in workspaceAgentPTY

This is version 2. Initially I implementedio.EOF closure propagation incoderd/turnconn.Conn, while I do think it may be a good idea, it's not necessary tofix#1508. I implemented it this way so that the fix can be utilized in the other handlers as well.

@mafredrimafredri self-assigned thisJun 2, 2022
@mafredrimafredri requested a review froma teamJune 2, 2022 12:47
@kylecarbs
Copy link
Member

An absolutely awesome fix@mafredri!

mafredri reacted with hooray emoji

@mafredrimafredriforce-pushed themafredri/fix-goroutine-leak branch from3f8c815 to9e6727eCompareJune 3, 2022 09:36
@mafredrimafredri merged commitb4f5920 intomainJun 3, 2022
@mafredrimafredri deleted the mafredri/fix-goroutine-leak branchJune 3, 2022 09:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Goroutine leak incoderd.(*api).workspaceAgentTurn
4 participants
@mafredri@kylecarbs@johnstcn@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp