Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add best effort attempt to revoke oauth access token in external auth provider#19775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pawbana merged 4 commits intomainfromoauth-revocation-15575
Sep 19, 2025

Conversation

pawbana
Copy link
Contributor

@pawbanapawbana commentedSep 11, 2025•
edited
Loading

Solves#15575
Adds OAuth access token revocation when unlinking external auth provider. Due to revocation not being consistently implemented by providers this is only best effort attempt. Unsuccessful revocation won't influence link removal.

@pawbanapawbana changed the titlefeat: add best effort attempt to revoke oauth access token in provider #15575feat: add best effort attempt to revoke oauth access token in providerSep 11, 2025
@pawbanapawbanaforce-pushed theoauth-revocation-15575 branch 3 times, most recently frome0c6a5e to8b82266CompareSeptember 16, 2025 07:49
@pawbanapawbana changed the titlefeat: add best effort attempt to revoke oauth access token in providerfeat: add best effort attempt to revoke oauth access token in external auth providerSep 16, 2025
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Backend review

@pawbanapawbanaforce-pushed theoauth-revocation-15575 branch 5 times, most recently from78554eb to93f15d9CompareSeptember 17, 2025 07:33
Comment on lines +418 to +419
require.Error(t,err)
require.Contains(t,err.Error(),"token validation failed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You can condenserequire.Error(); require.Contains(t, err.Error(), msg) intorequire.ErrorContains(t, err, msg)

Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Backend LGTM

@pawbanapawbana marked this pull request as ready for reviewSeptember 17, 2025 14:54
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

frontend looks much better! thanks

@pawbanapawbana merged commit439b041 intomainSep 19, 2025
36 checks passed
@pawbanapawbana deleted the oauth-revocation-15575 branchSeptember 19, 2025 14:27
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 19, 2025
CODER_EXTERNAL_AUTH_0_TYPE=github
CODER_EXTERNAL_AUTH_0_CLIENT_ID=xxxxxx
CODER_EXTERNAL_AUTH_0_CLIENT_SECRET=xxxxxxx
CODER_EXTERNAL_AUTH_0_REVOKE_URL=https://api.github.com/applications/<CLIENT ID>/grant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we instead inherit this automatically iftype=github.
We use the type to set defaults for known provides.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali left review comments

@deansheatherdeansheatherdeansheather left review comments

@ibetitsmikeibetitsmikeibetitsmike left review comments

@aslilacaslilacaslilac approved these changes

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner is a code owner

Assignees

@pawbanapawbana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@pawbana@aslilac@matifali@deansheather@ibetitsmike
[8]ページ先頭
©2009-2025 Movatter.jp