Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[2.26 backport] fix: pin pg_dump version when generating schema (#19696)#19765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kacpersaw merged 1 commit intorelease/2.26fromkacpersaw/cherry-pick/19696
Sep 11, 2025

Conversation

kacpersaw
Copy link
Contributor

This is required by#19756

The latest release of allpg_dump major versions, going back to 13, started inserting\restrict\unrestrict keywords into dumps. This currently breaks sqlc ingen/dump and our check migration script. Full details of the postgres change are available here:https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4c

To fix, we'll always use thepg_dump in our postgres 13.21 docker image for schema dumps, instead of what's on the runner/local machine.

Coder doesn't restore from postgres dumps, so we're not vulnerable to attacks that would be patched by the latest postgres version. Regardless, we'll unpin ASAP.

Once sqlc is updated to handle these keywords, we need to start stripping them when comparing the schema in the migration check script, and then we can unpin the pg_dump version. This is being tracked atcoder/internal#965

The latest release of all `pg_dump` major versions, going back to 13,started inserting `\restrict` `\unrestrict` keywords into dumps. Thiscurrently breaks sqlc in `gen/dump` and our check migration script. Fulldetails of the postgres change are available here:https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4cTo fix, we'll always use the `pg_dump` in our postgres 13.21 dockerimage for schema dumps, instead of what's on the runner/local machine.Coder doesn't restore from postgres dumps, so we're not vulnerable toattacks that would be patched by the latest postgres version.Regardless, we'll unpin ASAP.Once sqlc is updated to handle these keywords, we need to startstripping them when comparing the schema in the migration check script,and then we can unpin the pg_dump version. This is being tracked atcoder/internal#965
@kacpersawkacpersaw added the cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch labelSep 10, 2025
@kacpersawkacpersaw merged commitc0f1b9d intorelease/2.26Sep 11, 2025
33 of 34 checks passed
@kacpersawkacpersaw deleted the kacpersaw/cherry-pick/19696 branchSeptember 11, 2025 07:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@kacpersawkacpersaw

Labels
cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@kacpersaw@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp