Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor cli and coderd to use ClientOptions#19763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/refactor-more-client-builder
Sep 22, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 10, 2025•
edited
Loading

Refactors CLI and coderd to use the ClientBuilder pattern rather than directly instantiating the Client.

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 10, 2025 11:30
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 18, 2025
@spikecurtisspikecurtis removed the staleThis issue is like stale bread. labelSep 18, 2025
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from85affd4 to6cd9347CompareSeptember 18, 2025 09:48
@spikecurtisspikecurtisforce-pushed thespike/refactor-more-client-builder branch from4b8fa78 to6997c6dCompareSeptember 18, 2025 09:48
@spikecurtisspikecurtis changed the titlechore: refactor cli and coderd to use ClientBuilderchore: refactor cli and coderd to use ClientOptionsSep 18, 2025
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from6cd9347 toa8f5864CompareSeptember 18, 2025 10:13
@spikecurtisspikecurtisforce-pushed thespike/refactor-more-client-builder branch from6997c6d to41b5811CompareSeptember 18, 2025 10:13
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch froma8f5864 to7c7f61bCompareSeptember 22, 2025 11:48
@spikecurtisspikecurtisforce-pushed thespike/refactor-more-client-builder branch from41b5811 to434f5d5CompareSeptember 22, 2025 11:48
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from7c7f61b to52f9ef6CompareSeptember 22, 2025 12:01
@spikecurtisspikecurtisforce-pushed thespike/refactor-more-client-builder branch from434f5d5 to287c45cCompareSeptember 22, 2025 12:01
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 22, 2025•
edited
Loading

Merge activity

  • Sep 22, 1:13 PM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Sep 22, 1:40 PM UTC:Graphite rebased this pull request as part of a merge.
  • Sep 22, 1:51 PM UTC:Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'required', 'test-go-pg-17').

@spikecurtisspikecurtis changed the base branch fromspike/remove-client-from-server tographite-base/19763September 22, 2025 13:27
@spikecurtisspikecurtis changed the base branch fromgraphite-base/19763 tomainSeptember 22, 2025 13:38
@spikecurtisspikecurtisforce-pushed thespike/refactor-more-client-builder branch from287c45c to36552acCompareSeptember 22, 2025 13:39
@spikecurtisspikecurtis merged commita30c307 intomainSep 22, 2025
52 of 54 checks passed
@spikecurtisspikecurtis deleted the spike/refactor-more-client-builder branchSeptember 22, 2025 17:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp