Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: cleanup unused Client in server command#19762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/remove-client-from-server
Sep 22, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 10, 2025•
edited
Loading

As part of converting production code to use the new ClientBuilder, I noticed some dead code that creates a client with a URL for the only purpose of later accessing the URL. This PR removes the cruft.

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 10, 2025 11:29
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 18, 2025
@spikecurtisspikecurtisforce-pushed thespike/root-init-client-uses-builder branch frome9af6ff to7bb70d0CompareSeptember 18, 2025 09:48
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from85affd4 to6cd9347CompareSeptember 18, 2025 09:48
@spikecurtisspikecurtisforce-pushed thespike/root-init-client-uses-builder branch from7bb70d0 to91a055cCompareSeptember 18, 2025 10:13
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from6cd9347 toa8f5864CompareSeptember 18, 2025 10:13
@spikecurtisspikecurtis removed the staleThis issue is like stale bread. labelSep 18, 2025
@spikecurtisspikecurtisforce-pushed thespike/root-init-client-uses-builder branch from91a055c tobed0a70CompareSeptember 22, 2025 11:48
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch froma8f5864 to7c7f61bCompareSeptember 22, 2025 11:48
@spikecurtisspikecurtisforce-pushed thespike/root-init-client-uses-builder branch frombed0a70 to6c71e32CompareSeptember 22, 2025 12:00
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from7c7f61b to52f9ef6CompareSeptember 22, 2025 12:01
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 22, 2025•
edited
Loading

Merge activity

  • Sep 22, 1:13 PM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Sep 22, 1:28 PM UTC:Graphite rebased this pull request as part of a merge.
  • Sep 22, 1:38 PM UTC:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis changed the base branch fromspike/root-init-client-uses-builder tographite-base/19762September 22, 2025 13:15
@spikecurtisspikecurtis changed the base branch fromgraphite-base/19762 tomainSeptember 22, 2025 13:26
@spikecurtisspikecurtisforce-pushed thespike/remove-client-from-server branch from52f9ef6 tobd519a7CompareSeptember 22, 2025 13:27
@spikecurtisspikecurtis merged commit1734dfd intomainSep 22, 2025
32 checks passed
@spikecurtisspikecurtis deleted the spike/remove-client-from-server branchSeptember 22, 2025 13:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp