Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: refactor to directly create Client in Command Handlers#19760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/init-client-directly
Sep 22, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 10, 2025
edited
Loading

Refactors the CLI to create the*codersdk.Client in the handlers. This is groundwork for changing therootCmd.InitClient() to use the newClientOption​s.

It also improves variable locality, scoping the Client to the handler. This makes misuse less likely and reduces the memory allocations to just the command being executed, rather than allocating a Client for every command regardless of whether it is executed.

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 10, 2025 11:26
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 18, 2025
@spikecurtisspikecurtis removed the staleThis issue is like stale bread. labelSep 18, 2025
@spikecurtisspikecurtisforce-pushed thespike/init-client-directly branch 2 times, most recently from40ec132 tobe3c72eCompareSeptember 18, 2025 10:13
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm a 🪭!

@spikecurtisspikecurtis changed the base branch fromspike/client-builder tographite-base/19760September 22, 2025 11:59
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/19760 tomainSeptember 22, 2025 12:00
@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedSep 22, 2025
edited
Loading

Merge activity

  • Sep 22, 1:13 PM UTC: A user started a stack merge that includes this pull request viaGraphite.
  • Sep 22, 1:14 PM UTC:@spikecurtis merged this pull request withGraphite.

@spikecurtisspikecurtis merged commit606ae89 intomainSep 22, 2025
32 checks passed
@spikecurtisspikecurtis deleted the spike/init-client-directly branchSeptember 22, 2025 13:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp