Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: replace other deprecated Popovers which open on hover#19753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aqandrew merged 66 commits intomainfromaqandrew/replace-popover-hover
Sep 26, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
Show all changes
66 commits
Select commitHold shift + click to select a range
fba9492
refactor: replace Popover with Tooltip in AgentLatency
aqandrewAug 28, 2025
e230f38
refactor: replace PopoverTrigger with TooltipTrigger in AgentStatus
aqandrewAug 28, 2025
75c9fdf
refactor: replace PopoverTrigger with TooltipTrigger in
aqandrewAug 28, 2025
bea24d8
fix: remove HelpTooltipText from AgentLatency (div inside p)
aqandrewAug 28, 2025
9e6fa0c
fix: add TooltipProvider to AuditHelpTooltip
aqandrewAug 28, 2025
303222b
fix: add TooltipProvider to ConnectionLogHelpTooltip,
aqandrewAug 28, 2025
f835cb1
fix: add TooltipProvider to PublishTemplateVersionDialog
aqandrewAug 28, 2025
dd7e233
fix: add TooltipProvider to TemplateHelpTooltip
aqandrewAug 29, 2025
d397fff
fix: add TooltipProvider to WorkspaceHelpTooltip
aqandrewAug 29, 2025
6134bad
fix: add TooltipProvider to WorkspaceOurdatedTooltip
aqandrewAug 29, 2025
ad562be
fix: add TooltipProvider to SubAgentOutdatedTooltip
aqandrewAug 29, 2025
d30170c
fix: add TooltipProvider to EditRolesButton
aqandrewAug 29, 2025
4438af8
fix: add TooltipProvider to AutoCreateMissingGroupsHelpTooltip and
aqandrewAug 29, 2025
00b70ea
refactor: extract TooltipProvder to definition of HelpTooltip
aqandrewAug 29, 2025
c59daf3
refactor: remove extract TooltipProvider from DevContainerStartError
aqandrewAug 29, 2025
3aeaa49
test: add PublishDTemplateVersionDialog story
aqandrewAug 29, 2025
eaf3baf
chore: remove unused import
aqandrewAug 29, 2025
c93e092
refactor: rename Tooltip to MUITooltip
aqandrewAug 29, 2025
ef6cceb
refactor: replace Popover in OwnerBreadcrumb, WorkspaceBreadcrumb,
aqandrewAug 29, 2025
c142b5a
chore: check:fix
aqandrewAug 29, 2025
143e33e
Merge branch 'main' into aqandrew/replace-popover-in-helptooltip
aqandrewAug 29, 2025
d22a040
chore: lint:fix
aqandrewAug 29, 2025
2ff9e66
test: expect elements + text content rendered by HelpTooltip
aqandrewAug 29, 2025
ed5bf98
Revert "refactor: rename Tooltip to MUITooltip"
aqandrewAug 29, 2025
ff6c794
refactor: replace deprecated Popover in IconField
aqandrewAug 30, 2025
9887b09
refactor: move default collisionPadding from HelpTooltip to Popover
aqandrewSep 2, 2025
d859688
refactor: replace deprecated Popover in SelectMenu
aqandrewSep 3, 2025
bda70b2
style: prettier
aqandrewSep 3, 2025
6a37c49
refactor: replace deprecated Popover in DeploymentDropdown
aqandrewSep 3, 2025
6921bbe
style: prettier
aqandrewSep 3, 2025
423bddc
refactor: replace deprecated Popover in UserDropdown
aqandrewSep 3, 2025
81a70f3
refactor: remove redundant open state var from UserDropdown
aqandrewSep 3, 2025
949698b
refactor: replace deprecated Popover in UserDropdownContent.test
aqandrewSep 3, 2025
8207137
refactor: replace deprecated Popover in PortForwardButton
aqandrewSep 3, 2025
a6cf0da
refactor: replace deprecated Popover in EditRolesButton
aqandrewSep 3, 2025
183d163
refactor: replace deprecated Popover in ProvisionerTagsPopover
aqandrewSep 3, 2025
1242cbe
refactor: replace deprecated Popover in WorkspacesButton
aqandrewSep 3, 2025
1f9acc3
refactor: replace deprecated Popover in BuildParametersPopover
aqandrewSep 3, 2025
244792a
refactor: extract TemplateInsightsControls component
aqandrewSep 4, 2025
07fd1e2
test: use set past dateRange
aqandrewSep 4, 2025
8bd2cd0
test: add play functions to TemplateInsightsControls.stories
aqandrewSep 4, 2025
bdacfb1
refactor: replace deprecated Popover in DateRange
aqandrewSep 4, 2025
9e7b432
fix: remove unknown props from PopoverContent
aqandrewSep 4, 2025
5ba7da8
chore: check:fix
aqandrewSep 4, 2025
85611c3
refactor: don't export ClassName type
aqandrewSep 4, 2025
259e8a3
test: expect elements rendered by Popover
aqandrewSep 5, 2025
7b62b8a
test: add third mock organization to CreateOrganizationPageView
aqandrewSep 9, 2025
5e97617
test: add third mock group to IdpSyncPageView stories
aqandrewSep 9, 2025
b371230
refactor: replace other deprecated Popovers which open on hover
aqandrewSep 9, 2025
a869695
refactor: rename Tooltip to MUITooltip
aqandrewSep 9, 2025
942842f
refactor: replace deprecated Popover in UserRoleCell
aqandrewSep 10, 2025
44e14ac
refactor: replace deprecated Popover in UserGroupsCell
aqandrewSep 10, 2025
b2370af
refactor: replace deprecated Popover in Notifications
aqandrewSep 10, 2025
f75a147
refactor: factor out type import
aqandrewSep 10, 2025
ef1bfef
chore: delete deprecated Popover
aqandrewSep 10, 2025
7ce92b5
Merge branch 'main' into aqandrew/replace-popover-hover
aqandrewSep 24, 2025
61a5825
chore: check:fix
aqandrewSep 24, 2025
ac47694
chore: rm unused import
aqandrewSep 24, 2025
fd1de89
fix: define NotificationPillProps separately from NotificationsProps
aqandrewSep 24, 2025
204308f
test: select WorkspaceNotifications elements based on new Popover
aqandrewSep 24, 2025
296e81d
Merge branch 'main' into aqandrew/replace-popover-hover
aqandrewSep 25, 2025
d849863
test: await findByText promise instead of getByText
aqandrewSep 25, 2025
ce09afc
refactor: set Pill bg color w/ternary instead of object
aqandrewSep 26, 2025
050b2c4
style: fmt
aqandrewSep 26, 2025
05a81ea
refactor: set OrganizationPills bg color w/ternary instead of object
aqandrewSep 26, 2025
66556a3
Merge branch 'main' into aqandrew/replace-popover-hover
aqandrewSep 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 0 additions & 57 deletionssite/src/components/deprecated/Popover/Popover.stories.tsx
View file
Open in desktop

This file was deleted.

245 changes: 0 additions & 245 deletionssite/src/components/deprecated/Popover/Popover.tsx
View file
Open in desktop

This file was deleted.

View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,8 @@ const Example: Story = {

await step("click to open", async () => {
await userEvent.click(canvas.getByRole("button"));
await waitFor(() =>
expect(screen.getByText(/v2\.\d+\.\d+/i)).toBeInTheDocument(),
await waitFor(async() =>
expect(awaitscreen.findByText(/v2\.\d+\.\d+/i)).toBeInTheDocument(),
Comment on lines +33 to +34
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

);
});
},
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,17 +7,18 @@ import {
PremiumBadge,
} from "components/Badges/Badges";
import { Button } from "components/Button/Button";
import {
Popover,
PopoverContent,
PopoverTrigger,
} from "components/deprecated/Popover/Popover";
import { PopoverPaywall } from "components/Paywall/PopoverPaywall";
import {
SettingsHeader,
SettingsHeaderDescription,
SettingsHeaderTitle,
} from "components/SettingsHeader/SettingsHeader";
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from "components/Tooltip/Tooltip";
import { useFormik } from "formik";
import type { FC } from "react";
import { getFormHelpers } from "utils/formUtils";
Expand DownExpand Up@@ -66,25 +67,31 @@ export const AppearanceSettingsPageView: FC<
</SettingsHeader>

<Badges>
<Popover mode="hover">
{isEntitled && !isPremium ? (
<EnterpriseBadge />
) : (
<PopoverTrigger>
<span>
<PremiumBadge />
</span>
</PopoverTrigger>
)}
<TooltipProvider>
<Tooltip delayDuration={0}>
{isEntitled && !isPremium ? (
<EnterpriseBadge />
) : (
<TooltipTrigger asChild>
<span>
<PremiumBadge />
</span>
</TooltipTrigger>
)}

<PopoverContent css={{ transform: "translateY(-28px)" }}>
<PopoverPaywall
message="Appearance"
description="With a Premium license, you can customize the appearance and branding of your deployment."
documentationLink="https://coder.com/docs/admin/appearance"
/>
</PopoverContent>
</Popover>
<TooltipContent
sideOffset={-28}
collisionPadding={16}
className="p-0"
>
<PopoverPaywall
message="Appearance"
description="With a Premium license, you can customize the appearance and branding of your deployment."
documentationLink="https://coder.com/docs/admin/appearance"
/>
</TooltipContent>
</Tooltip>
</TooltipProvider>
</Badges>

<Fieldset
Expand Down
Loading
Loading

[8]ページ先頭

©2009-2025 Movatter.jp