Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: remove agent name from app URLs#19750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rafrdz merged 3 commits intomainfromrafrdz/remove-agent-name
Sep 26, 2025
Merged

Conversation

rafrdz
Copy link

Summary

In this pull request we're removingagent_name from subdomains in APP urls when anapp is used in the subdomain.agent_names will still be used when aport is used in the subdomain.

Closes:#18485

Changes

  • Updated regex to support an optional agent name
  • Added logic to support checking the app slug for a matching port (e.g., 8080 or 8080s)

Testing

  • Updated all tests to support an optionalagent_name

@rafrdzrafrdz marked this pull request as ready for reviewSeptember 11, 2025 23:50
@rafrdzrafrdz requested a review fromEmyrkSeptember 15, 2025 17:16
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 23, 2025
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like this was already partially supported 👍

// AgentNameOrID is not required if the workspace has only one agent.
AgentNameOrIDstring`json:"agent_name_or_id"`

rafrdz reacted with hooray emoji
@rafrdzrafrdz merged commitd29a524 intomainSep 26, 2025
31 checks passed
@rafrdzrafrdz deleted the rafrdz/remove-agent-name branchSeptember 26, 2025 17:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 26, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@rafrdzrafrdz

Labels
staleThis issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: remove agent name from app URLs
2 participants
@rafrdz@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp