- Notifications
You must be signed in to change notification settings - Fork1k
fix: add xmlns attribute to amazon-q.svg for proper rendering#19738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The amazon-q.svg icon was not rendering properly in browsers because it was missing the xmlns attribute. This attribute is required for browsers to properly identify and render SVG content when loaded as images.Fixes the broken icon display on the icons page.
ethanndickson approved these changesSep 8, 2025
10 tasks
d7d69d1 intomain 38 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
cherry-pick/v2.24Needs to be cherry-picked to the 2.24 release branch cherry-pick/v2.25Needs to be cherry-picked to the 2.25 release branch cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
amazon-q.svgicon was not rendering properly in browsers, appearing as a broken image on the icons page.Root Cause
The SVG was missing the
xmlns="http://www.w3.org/2000/svg"attribute, which is required for browsers to properly identify and render SVG content when loaded as images.Solution
Added the missing
xmlnsattribute to the<svg>element.Testing
✅ Verified the icon now renders correctly in browsers
✅ Tested on both light and dark backgrounds
✅ Confirmed the fix resolves the broken icon display
Before: Broken image icon
After: Proper blue gradient Amazon Q logo