- Notifications
You must be signed in to change notification settings - Fork1k
fix: support path parameters in OAuth2 metadata endpoints#19729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ThomasK33 merged 1 commit intomainfromthomask33/fix_support_path_parameters_in_OAuth2_metadata_endpointsSep 8, 2025
Merged
fix: support path parameters in OAuth2 metadata endpoints#19729
ThomasK33 merged 1 commit intomainfromthomask33/fix_support_path_parameters_in_OAuth2_metadata_endpointsSep 8, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
74161dd to29c7d1cCompareChange-Id: Ic28d30af39fcb3c8eea40607e0241c5aa096cc80Signed-off-by: Thomas Kosiewski <tk@coder.com>
29c7d1c toeab2971Comparespikecurtis approved these changesSep 8, 2025
2701d55 intomain 32 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OAuth2 metadata endpoint routes to support path suffixes
This PR updates the OAuth2 metadata endpoint routes to include a wildcard character (*) at the end of the paths. This change allows the endpoints to match requests with path suffixes, making our OAuth2 discovery implementation more flexible and compliant with the relevant RFCs.
The updated routes are:
/.well-known/oauth-authorization-server*for RFC 8414 discovery/.well-known/oauth-protected-resource*for RFC 9728 discovery