Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Workspaces filtering#1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
f0ssel merged 23 commits intomainfromf0ssel/workspace-filter
Jun 3, 2022
Merged

feat: Workspaces filtering#1972

f0ssel merged 23 commits intomainfromf0ssel/workspace-filter
Jun 3, 2022

Conversation

f0ssel
Copy link
Contributor

@f0sself0ssel commentedJun 1, 2022•
edited
Loading

Okay third time is the charm. This one I'd actually like to get merged.

Discussion at#1820

This PR adds a workspace filter to the workspaces page. It uses the backend and it defaults to the workspaces you own, and there's buttons to see all workspaces and a filter bar. Right now the filter bar only functions with theowner: query filter.

chrome_zNVFzNQXaq

Next steps:

  • Work with / hand off to a frontend person to help with styling issues
  • Correctly handle 400 error cases where we should show no workspaces
  • Support plain words as a workspace name filter (requires backend changes, probably different PR)

kylecarbs reacted with eyes emoji
@f0sself0ssel requested a review froma team as acode ownerJune 1, 2022 23:39
@f0ssel
Copy link
ContributorAuthor

f0ssel commentedJun 1, 2022•
edited
Loading

I'd like help if someone with styling experience wants to fix the issues with sizing / alignment between the button and filter field and the length of the text field itself. I'm trying to emulate the look and feel of the issue query bar on Github, for example:
image

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please add all product copy into aLanguage object (example the words "Your workspaces" and "All workspaces" in theWorkspacePage

Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nicely done@f0ssel . All code comments are really nit, this is fantastic.

@ammario
Copy link
Member

Yay for the (scalable) backend implementation.

What should be/is the behavior if no term is provided? For example, if I just searched "ammario" and not "owner:ammario" what should happen?

@f0ssel
Copy link
ContributorAuthor

f0ssel commentedJun 2, 2022•
edited
Loading

Yay for the (scalable) backend implementation.

What should be/is the behavior if no term is provided? For example, if I just searched "ammario" and not "owner:ammario" what should happen?

Right now that's not implemented so it's just ignored. I want to make plain strings (noowner: prefix) to just do a search on workspace name, but that isn't supported on the backend yet.

@ammario
Copy link
Member

I think that's right@f0ssel. The interesting thing is the search could be against the fully qualified workspace name, so you technically use that to search for owner as well.

@f0ssel
Copy link
ContributorAuthor

@ammario I added this suggestion, why don't you take a look at this logic and let me know if you would expect different behavior:https://github.com/coder/coder/pull/1972/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57R198-R229

@ammario
Copy link
Member

ammario commentedJun 2, 2022•
edited
Loading

@ammario I added this suggestion, why don't you take a look at this logic and let me know if you would expect different behavior:https://github.com/coder/coder/pull/1972/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57R198-R229

That was a fun exercise of some of my older neurons. That LGTM! I'm excited to see this in action.

f0ssel reacted with thumbs up emoji

@f0sself0sselforce-pushed thef0ssel/workspace-filter branch frome47b601 to2912d03CompareJune 2, 2022 21:12
f0sseland others added2 commitsJune 2, 2022 21:13
Co-authored-by: G r e y <grey@coder.com>
@f0ssel
Copy link
ContributorAuthor

Will be getting some styling fixes in soon, but here's a demo of the current functionality:
chrome_BgiGT3ZExx

@ammario
Copy link
Member

I like the UX. The flicker is a bit jank, but I know you realize that too.

f0ssel reacted with thumbs up emoji

@tjcrantjcran mentioned this pull requestJun 3, 2022
@f0ssel
Copy link
ContributorAuthor

After some awesome styling work from@Kira-Pilot I think this is ready to merge, will be tagging for final reviews.

chrome_8JHeeyht9E

ammario reacted with hooray emoji

@f0sself0ssel requested review froma team andammarioJune 3, 2022 16:17
@Kira-Pilot
Copy link
Member

great job braving the FE!

@f0sself0sselenabled auto-merge (squash)June 3, 2022 17:10
@f0sself0ssel merged commit8b03e2b intomainJun 3, 2022
@f0sself0ssel deleted the f0ssel/workspace-filter branchJune 3, 2022 17:20
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
Co-authored-by: G r e y <grey@coder.com>Co-authored-by: Kira Pilot <kira@coder.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@greyscaledgreyscaledgreyscaled left review comments

@johnstcnjohnstcnjohnstcn approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

@ammarioammarioAwaiting requested review from ammario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@f0ssel@ammario@Kira-Pilot@johnstcn@greyscaled@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp