Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(docs): add wildcard access url documentation page#19713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
david-fraley merged 9 commits intomainfromkacpersaw/feat-wildcard-access-url-docs
Sep 12, 2025

Conversation

kacpersaw
Copy link
Contributor

Closes#19607

This pull request adds a new guide about wildcard access URLs.

@kacpersawkacpersawforce-pushed thekacpersaw/feat-wildcard-access-url-docs branch from3ab9114 tobc3b0f3CompareSeptember 5, 2025 13:07
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think from a correctness standpoint it's pretty good. Would like someone from product to approve, though

Co-authored-by: Dean Sheather <dean@deansheather.com>
@kacpersawkacpersaw requested review frommatifali and removed request formatifaliSeptember 11, 2025 10:16
@matifalimatifali marked this pull request as ready for reviewSeptember 11, 2025 10:45
@matifali
Copy link
Member

@david-fraley can you please review too?

david-fraley reacted with eyes emoji

Copy link
Collaborator

@david-fraleydavid-fraley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few nitpicks, but otherwise I think the page is good to go. Not gonna let those hold things up

Comment on lines 27 to 28
> [!TIP]
> For complete setup instructions, see [Wildcard Access URL Configuration](../setup/index.md#wildcard-access-url) in the main setup guide.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I followed this link, and don't think the linked guide is actually much more helpful at all. What y'all have got here is much more comprehensive, so I'd consider dropping this link. That page also links back to this one so it's a bit circular.

matifali reacted with thumbs up emoji
kacpersawand others added2 commitsSeptember 12, 2025 18:27
Co-authored-by: david-fraley <67079030+david-fraley@users.noreply.github.com>
@david-fraleydavid-fraley merged commitf9f0ebb intomainSep 12, 2025
31 checks passed
@david-fraleydavid-fraley deleted the kacpersaw/feat-wildcard-access-url-docs branchSeptember 12, 2025 18:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 12, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather left review comments

@david-fraleydavid-fraleydavid-fraley approved these changes

@matifalimatifaliAwaiting requested review from matifali

Assignees

@kacpersawkacpersaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document importance of configuring wildcard access URL
4 participants
@kacpersaw@matifali@deansheather@david-fraley
[8]ページ先頭
©2009-2025 Movatter.jp