Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Update UI for error dialog and snackbar#1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AbhineetJain merged 2 commits intomainfromabhineetjain/1832-confirmation-dialog
Jun 2, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJainAbhineetJain commentedJun 1, 2022•
edited
Loading

This PR updates the alarmingly red UI for error dialog and snackbars.

Subtasks

  • update the UI for error type dialog box
  • update the UI for error type snackbar

Fixes#1832

Screenshot

image

image

@AbhineetJainAbhineetJain requested a review froma team as acode ownerJune 1, 2022 23:36
@BrunoQuaresma
Copy link
Collaborator

Can we make these buttons have the same height than the form buttons?

@BrunoQuaresma
Copy link
Collaborator

Also, adding some extra padding in the wrapper to looks closer to the Figma file.

@AbhineetJain
Copy link
ContributorAuthor

Can we make these buttons have the same height than the form buttons?

Sure, let me do that.

@AbhineetJain
Copy link
ContributorAuthor

Also, adding some extra padding in the wrapper to looks closer to the Figma file.

I realized I'll need changes in multiple places to update the other dialogs as well. Let me try those changes.

@AbhineetJain
Copy link
ContributorAuthor

@BrunoQuaresma I updated the extra padding forConfirmDialog, but theResetPasswordDialog is differently styled. Should we update the formatting for that too?

@AbhineetJainAbhineetJainforce-pushed theabhineetjain/1832-confirmation-dialog branch fromb11e716 to0d5e026CompareJune 2, 2022 00:32
Copy link
Contributor

@greyscaledgreyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Certainly looks like an improvement to me!@BrunoQuaresma's been doing a lot of re-design work lately (and is a fantastic designer 🎨), I'm delegating review towards him.

Nice job y'all!

@Kira-Pilot
Copy link
Member

Wow! Looking way better. I'll also defer to Bruno, but nice job!

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! I think we should make the same for the Confirmation dialog and success alert as well but using the green color.@AbhineetJain what do you think? We probably can do it in another ticket or diff PR. Good job!

@AbhineetJain
Copy link
ContributorAuthor

AbhineetJain commentedJun 2, 2022•
edited
Loading

@BrunoQuaresma Sounds good, thank you! I'll create an issue for that, let's discuss it more there.

Edit:#1984

@AbhineetJainAbhineetJain merged commite09cd3e intomainJun 2, 2022
@AbhineetJainAbhineetJain deleted the abhineetjain/1832-confirmation-dialog branchJune 2, 2022 15:23
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* feat: update ui for error dialog and snackbar* update padding for buttons
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@greyscaledgreyscaledgreyscaled approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Confirmation Dialogs and Snackbar Notifs have an alarming red
4 participants
@AbhineetJain@BrunoQuaresma@Kira-Pilot@greyscaled
[8]ページ先頭
©2009-2025 Movatter.jp