- Notifications
You must be signed in to change notification settings - Fork1k
refactor: replace deprecated Popovers which open on click#19709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AgentOutdatedTooltip
IdpOrgSyncPageView, TableColumnHelpTooltip, TemplateInsightsPage
LegacyGroupSyncHeader
OrganizationBreadcrumb
This reverts commitc93e092.
PopoverClose from Popover component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lots of good stuff! thanks!
| constcanvas=within(canvasElement); | ||
| constbutton=canvas.getByRole("button"); | ||
| awaituserEvent.click(button); | ||
| constmenu=canvasElement.querySelector<HTMLElement>("[role=menu]")!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
muuuuch better
Uh oh!
There was an error while loading.Please reload this page.
| import{typeDependencyList,useMemo}from"react"; | ||
| exporttypeClassName=(cssFn:typeofcss,theme:Theme)=>string; | ||
| typeClassName=(cssFn:typeofcss,theme:Theme)=>string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this means we're getting closer!! excited to see this old hack gone
Co-authored-by: ケイラ <mckayla@hey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks really, really good. Just had a few suggestions
site/src/modules/dashboard/Navbar/UserDropdown/UserDropdownContent.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
site/src/modules/dashboard/Navbar/UserDropdown/UserDropdownContent.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| color:theme.palette.text.secondary, | ||
| "&:hover .rdrStaticRangeLabel":{ | ||
| "&:is(:hover, :focus) .rdrStaticRangeLabel":{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Slick
| @@ -0,0 +1,47 @@ | |||
| importtype{Meta,StoryObj}from"@storybook/react-vite"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🙏
site/src/pages/WorkspacePage/WorkspaceActions/BuildParametersPopover.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
| <Link | ||
| href={`/@${workspace.owner_name}/${workspace.name}/settings/parameters`} | ||
| className="self-start" | ||
| > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oof, great update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Blink wrote the original<Button> version of this. Hopefully there will come a day when LLMs can be trained on semantic HTML 🥴
site/src/pages/WorkspacePage/WorkspaceActions/RetryButton.stories.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/WorkspacePage/WorkspaceActions/RetryButton.stories.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/WorkspacePage/WorkspaceActions/RetryButton.stories.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
669984c intomainUh oh!
There was an error while loading.Please reload this page.
for#19397
dependency:#19635
This PR specifically covers components which open a popover that's triggered by a click, rather than a hover.