Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: addsharing show command to the CLI#19707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brettkolodny merged 3 commits intomainfrombrett/i860
Sep 8, 2025
Merged

Conversation

brettkolodny
Copy link
Contributor

@brettkolodnybrettkolodny commentedSep 4, 2025•
edited
Loading

@brettkolodnybrettkolodny marked this pull request as ready for reviewSeptember 5, 2025 14:36
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me.

Non-blocking: It might be worth adding an extra test to ensure the command doesn't output users that the workspace isn't shared with. I realize this is probably already tested at the API level so not massively important to me

@brettkolodny
Copy link
ContributorAuthor

I realize this is probably already tested at the API level so not massively important to me

Yeah I had the same thought. It adds a lot more code to the tests and I don't think it'd be worth it when it's already being tested on API level

DanielleMaywood reacted with thumbs up emoji

@brettkolodnybrettkolodny merged commit065c7c3 intomainSep 8, 2025
69 of 75 checks passed
@brettkolodnybrettkolodny deleted the brett/i860 branchSeptember 8, 2025 13:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@brettkolodnybrettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coder sharing show command
2 participants
@brettkolodny@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp