Sep 8, 2025 · Sep 4, 2025 · Sep 4, 2025 · Sep 4, 2025 · Sep 4, 2025
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/...e/migrations/000363_optimize_getprovisionerdaemonswithstatusbyorganization_query.down.sql b/...e/migrations/000363_optimize_getprovisionerdaemonswithstatusbyorganization_query.down.sql
 DROP INDEX provisioner_jobs_worker_id_organization_id_completed_at_idx;
diff --git a/...ase/migrations/000363_optimize_getprovisionerdaemonswithstatusbyorganization_query.up.sql b/...ase/migrations/000363_optimize_getprovisionerdaemonswithstatusbyorganization_query.up.sql
 CREATE INDEX provisioner_jobs_worker_id_organization_id_completed_at_idx ON provisioner_jobs (worker_id, organization_id, completed_at DESC NULLS FIRST);

 COMMENT ON INDEX provisioner_jobs_worker_id_organization_id_completed_at_idx IS 'Support index for finding the latest completed jobs for a worker (and organization), nulls first so that active jobs have priority; targets: GetProvisionerDaemonsWithStatusByOrganization';
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		DROP INDEX provisioner_jobs_worker_id_organization_id_completed_at_idx;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		CREATE INDEX provisioner_jobs_worker_id_organization_id_completed_at_idx ON provisioner_jobs (worker_id, organization_id, completed_at DESC NULLS FIRST);
Copy link Member johnstcnSep 4, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. What impact did`NULLS FIRST` show versus without in your testing? Copy link MemberAuthor mafredriSep 4, 2025• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It's negligible because there are 0 uncompleted jobs in the clone I have. It does get rid of one sort, and should provide a benefit for larger datasets and lots of in flight jobs.

		COMMENT ON INDEX provisioner_jobs_worker_id_organization_id_completed_at_idx IS 'Support index for finding the latest completed jobs for a worker (and organization), nulls first so that active jobs have priority; targets: GetProvisionerDaemonsWithStatusByOrganization';