Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: pin pg_dump version when generating schema for 2.24#19698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stirby merged 1 commit intorelease/2.24fromcherry-pick-pg-24
Sep 4, 2025

Conversation

stirby
Copy link
Collaborator

Cherry-pick for release v2.24.4.
#19696

The latest release of all `pg_dump` major versions, going back to 13,started inserting `\restrict` `\unrestrict` keywords into dumps. Thiscurrently breaks sqlc in `gen/dump` and our check migration script. Fulldetails of the postgres change are available here:https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4cTo fix, we'll always use the `pg_dump` in our postgres 13.21 dockerimage for schema dumps, instead of what's on the runner/local machine.Coder doesn't restore from postgres dumps, so we're not vulnerable toattacks that would be patched by the latest postgres version.Regardless, we'll unpin ASAP.Once sqlc is updated to handle these keywords, we need to startstripping them when comparing the schema in the migration check script,and then we can unpin the pg_dump version. This is being tracked atcoder/internal#965(cherry picked from commit1b4ce09)
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedSep 4, 2025
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by theCLA Assistant Lite bot.

@stirbystirby changed the base branch frommain torelease/2.24September 4, 2025 04:06
@stirbystirby changed the titlefix: pin pg_dump version when generating schema (#19696)fix: pin pg_dump version when generating schema for 2.24Sep 4, 2025
@stirbystirby merged commitecc6d53 intorelease/2.24Sep 4, 2025
8 of 9 checks passed
@stirbystirby deleted the cherry-pick-pg-24 branchSeptember 4, 2025 04:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@ParkreinerParkreinerAwaiting requested review from Parkreiner

@aslilacaslilacAwaiting requested review from aslilac

@EmyrkEmyrkAwaiting requested review from Emyrk

Assignees

@stirbystirby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@stirby@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp