- Notifications
You must be signed in to change notification settings - Fork1k
fix: pin pg_dump version when generating schema#19696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+21 −17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9ed9a49
to45f79b9
Compareed453b2
to7cceb5f
Comparestirby approved these changesSep 4, 2025
e56a33b
toe56e8f1
Comparee56e8f1
toaeabc50
Compare1b4ce09
intomain 51 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The latest release of all
pg_dump
major versions, going back to 13, started inserting\restrict
\unrestrict
keywords into dumps. This currently breaks sqlc ingen/dump
and our check migration script. Full details of the postgres change are available here:https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4cTo fix, we'll always use the
pg_dump
in our postgres 13.21 docker image for schema dumps, instead of what's on the runner/local machine.Coder doesn't restore from postgres dumps, so we're not vulnerable to attacks that would be patched by the latest postgres version. Regardless, we'll unpin ASAP.
Once sqlc is updated to handle these keywords, we need to start stripping them when comparing the schema in the migration check script, and then we can unpin the pg_dump version. This is being tracked atcoder/internal#965