Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: pin pg_dump version when generating schema#19696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/pg-dump-pin
Sep 4, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 4, 2025
edited
Loading

The latest release of allpg_dump major versions, going back to 13, started inserting\restrict\unrestrict keywords into dumps. This currently breaks sqlc ingen/dump and our check migration script. Full details of the postgres change are available here:https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4c

To fix, we'll always use thepg_dump in our postgres 13.21 docker image for schema dumps, instead of what's on the runner/local machine.

Coder doesn't restore from postgres dumps, so we're not vulnerable to attacks that would be patched by the latest postgres version. Regardless, we'll unpin ASAP.

Once sqlc is updated to handle these keywords, we need to start stripping them when comparing the schema in the migration check script, and then we can unpin the pg_dump version. This is being tracked atcoder/internal#965

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson changed the titlefix: avoid using pg_dump 17.0 or higher when generating schemafix: pin pg_dump when generating schemaSep 4, 2025
@ethanndicksonethanndicksonforce-pushed theethan/pg-dump-pin branch 2 times, most recently fromed453b2 to7cceb5fCompareSeptember 4, 2025 03:33
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 4, 2025 03:36
@ethanndicksonethanndicksonforce-pushed theethan/pg-dump-pin branch 2 times, most recently frome56a33b toe56e8f1CompareSeptember 4, 2025 03:43
@ethanndicksonethanndickson changed the titlefix: pin pg_dump when generating schemafix: pin pg_dump version when generating schemaSep 4, 2025
@ethanndicksonethanndickson merged commit1b4ce09 intomainSep 4, 2025
51 checks passed
@ethanndicksonethanndickson deleted the ethan/pg-dump-pin branchSeptember 4, 2025 04:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@stirbystirbystirby approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@stirby

[8]ページ先頭

©2009-2025 Movatter.jp