Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add default workspace name to Template Embed form#19688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mtojek merged 8 commits intomainfromembed-workspace-name
Sep 8, 2025

Conversation

mtojek
Copy link
Member

Fixes:#15798

This PR extends the Template Embed form to include "default workspace name". The logic handling the "name" GET parameter was already implemented a while ago.

Screenshot 2025-09-03 at 13 22 03

@mtojekmtojek self-assigned thisSep 3, 2025
@mtojekmtojek marked this pull request as ready for reviewSeptember 3, 2025 11:59
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The overall approach looks good to me – just had some concerns about some of the finer details

@mtojekmtojek requested a review fromaslilacSeptember 5, 2025 09:33
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Checked the stories, and everything looks good. Appreciate you adding a new story for the error case

@mtojekmtojek merged commit5c1a708 intomainSep 8, 2025
31 of 32 checks passed
@mtojekmtojek deleted the embed-workspace-name branchSeptember 8, 2025 11:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ParkreinerParkreinerParkreiner approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac is a code owner

Assignees

@mtojekmtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add workspace name to "Embed" section of templates UI
3 participants
@mtojek@aslilac@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp