- Notifications
You must be signed in to change notification settings - Fork1k
fix: change enqueue error to debug log level#19686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm happy to merge this if you think it's innocent, but it is somewhat strange this test went from 0 to 2 failures just today..
here's the other failure:https://github.com/coder/coder/actions/runs/17423933022/job/49467317208
I don't think it is simple coincidence that we started seeing failures. Still, I'm confident it's benign. Each mapper runs in a goroutine that selects work to do or context cancellation. When a peer disconnects we cancel the context and close the ConnIO. There is a race between work in progress and cancellation. As the test suite changes the timing of different things in goroutines can shift around for reasons unrelated to the test whose outcome changes. This flaky logging condition was always there, but for whatever reason we didn't hit it in our test suite until recently. |
04dfda8
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
fixescoder/internal#958
Logging was being done at error level, but most likely any errors are from simple races between an update triggered around the same time as a client disconnecting. Debug is fine for these.