Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: change enqueue error to debug log level#19686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/internal-958-pgcoord-log
Sep 3, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedSep 3, 2025
edited
Loading

fixescoder/internal#958

Logging was being done at error level, but most likely any errors are from simple races between an update triggered around the same time as a client disconnecting. Debug is fine for these.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewSeptember 3, 2025 09:02
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm happy to merge this if you think it's innocent, but it is somewhat strange this test went from 0 to 2 failures just today..

here's the other failure:https://github.com/coder/coder/actions/runs/17423933022/job/49467317208

@spikecurtisGraphite App
Copy link
ContributorAuthor

I don't think it is simple coincidence that we started seeing failures. Still, I'm confident it's benign. Each mapper runs in a goroutine that selects work to do or context cancellation. When a peer disconnects we cancel the context and close the ConnIO. There is a race between work in progress and cancellation.

As the test suite changes the timing of different things in goroutines can shift around for reasons unrelated to the test whose outcome changes. This flaky logging condition was always there, but for whatever reason we didn't hit it in our test suite until recently.

@spikecurtisspikecurtis merged commit04dfda8 intomainSep 3, 2025
35 checks passed
@spikecurtisspikecurtis deleted the spike/internal-958-pgcoord-log branchSeptember 3, 2025 09:42
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestPGCoordinatorDual_Mainline
2 participants
@spikecurtis@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp