Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(cli/templatepush): only implicitly read from stdin if the directory flag is unset#19681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/fix-unintentional-stdin
Sep 4, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 3, 2025
edited
Loading

In trying to address confusion with the- (for stdin) directory flag last year, I hadtemplate push read from stdin if stdin was not a TTY. However, I made the mistake of checking if the directory flag was set or not by comparing it to the default value. This meant in something like GitHub Actions, where you don't have a TTY for stdin, it was impossible to read from the current working directory. The fix is just to check if the flag was explicitly set, using pflags.

If users encounter this bug, and this fix is unavailable in their version of Coder, they can workaround it by setting-d "$(pwd)"

@ethanndicksonGraphite App
Copy link
MemberAuthor

@ethanndicksonethanndicksonforce-pushed theethan/fix-unintentional-stdin branch from58a6752 to32ee661CompareSeptember 3, 2025 01:18
@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 3, 2025 01:25
@ethanndicksonethanndickson merged commitf867a9d intomainSep 4, 2025
39 checks passed
@ethanndicksonethanndickson deleted the ethan/fix-unintentional-stdin branchSeptember 4, 2025 04:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp