NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

chore(cli): re-order CLI create command#19658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

DanielleMaywood merged 7 commits intomainfromdanielle/tasks/reorder-create-cli-args

Sep 2, 2025

Merged

chore(cli): re-order CLI create command#19658

DanielleMaywood merged 7 commits intomainfromdanielle/tasks/reorder-create-cli-args

Sep 2, 2025

Conversation

Copy link

Contributor

DanielleMaywood commentedSep 1, 2025

Relates tocoder/internal#893

Instead ofcoder task create <template> --input <input>, it is nowcoder task create <input> --template <template>.

If there is only one AI task template on the deployment, the--template parameter can be omitted.

github-actionsbot assignedDanielleMaywood

Sep 1, 2025

DanielleMaywood force-pushed thedanielle/tasks/reorder-create-cli-args branch from86adf7a to0fe358dCompare

September 1, 2025 12:46

chore(cli): re-order CLI create command

3071ef8

Relates tocoder/internal#893Instead of `coder task create <template> --input <input>`, it is now`coder task create <input> --template <template>`.If there is only one AI task template on the deployment, the `--template`parameter can be omitted.

DanielleMaywood force-pushed thedanielle/tasks/reorder-create-cli-args branch from0fe358d to3071ef8Compare

September 1, 2025 13:11

DanielleMaywood marked this pull request as ready for review

September 1, 2025 13:22

DanielleMaywood requested review fromjohnstcn,mafredri andmatifali

September 1, 2025 13:22

mafredri reviewed

Sep 1, 2025

View reviewed changes

Copy link

Member

mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this new approach will ultimately be better, thanks for implementing! Some feedback inline.

cli/exp_task_create.go OutdatedShow resolvedHide resolved

cli/exp_task_create.goShow resolvedHide resolved

matifali approved these changes

Sep 1, 2025

View reviewed changes

Copy link

Member

matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks <3. 🚢

Should we mark this as breaking change?

cli/exp_task_create.go

		Flag:"input",
		Env:"CODER_TASK_INPUT",
		Value:serpent.StringOf(&taskInput),
		Required:true,

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does it mean we can start a task without an input? i.e., an empty prompt? Should we allow that?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this may end up happening in a prebuild scenario?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe, yes. Prebuilds are tricky.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think we should start tasks without input necessarily, but who's to say there isn't a default input that's only controlled by e.g. template parameters. This was one motivation that--input was made a flag previously.

Copy link

ContributorAuthor

DanielleMaywoodSep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have added a check to disallow empty task input

Copy link

Member

mafredri commentedSep 1, 2025

Should we mark this as breaking change?

No need, this is exactly why we placed these underexp. No announcement for release yet either.

johnstcn approved these changes

Sep 1, 2025

View reviewed changes

Copy link

Member

johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nothing to add beyond what@mafredri already mentioned. Nice work! 👍

cli/exp_task_create.go OutdatedShow resolvedHide resolved

Copy link

Member

matifali commentedSep 1, 2025•
edited
Loading

Should we mark this as breaking change?
No need, this is exactly why we placed these underexp. No announcement for release yet either.

But many of our customers are using Tasks. So I was just being extra cautious not to break their workflows without any information.exp gives us the freedom to break, but we should still announce this commit as a breaking change in the changelog.

Copy link

Member

mafredri commentedSep 1, 2025•
edited
Loading

But many of our customers are using Tasks. So I was just being extra cautious not to break their workflows without any information.exp gives us the freedom to break, but we should still announce this commit as a breaking change in the changelog.

I don't have a strong opinion. We don't documentexp commands and we haven't advertised the tasks CLI commands in the release. But if you feel it should be called out then let's do it. 👍🏻 (@DanielleMaywood, didcreate slip into the release?)

Copy link

Member