- Notifications
You must be signed in to change notification settings - Fork1k
feat: add coder_workspace_ls MCP tool#19652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
577ae7e toa5b63d6Compared82a0ff to1f7ae1fComparea5b63d6 tofd0c2feCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, but you might want to get a second opinion, though.
code-asher commentedSep 11, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ethanndickson I think you added the |
fd0c2fe tod0f190aCompareYikes, sorry all for the pings, it happened when I was changing the base... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tested it live w/ Coder Desktop & A Linux workspace, just in case of any subtle regressions, but it lgtm! (sans the compile error)
| t.Parallel() | ||
| query:=LSRequest{ | ||
| fs:=afero.NewMemMapFs() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for plumbing this through!
| // `contents` may be partially populated even if the operation fails midway. | ||
| contents,_:=f.ReadDir(-1) | ||
| respContents:=make([]LSFile,0,len(contents)) | ||
| contents,_:=f.Readdir(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's a shame Afero doesn't exposeReadDir here :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Too true 😢
| ctx,span:=tracing.StartSpan(ctx) | ||
| deferspan.End() | ||
| res,err:=c.apiRequest(ctx,http.MethodPost,fmt.Sprintf("/api/v0/list-directory?path=%s",path),req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fails to compile - not sure why CI isn't running though..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ahh oops I messed up the base 🤦
d0f190a to7996bbfCompare7996bbf toc12e740Comparebe7aa58 intomainUh oh!
There was an error while loading.Please reload this page.
A continuation from#19629