Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add tooltip field to workspace app that renders as markdown#19651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rafrdz merged 21 commits intomainfromrafrdz/tooltip-support
Sep 10, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
Show all changes
21 commits
Select commitHold shift + click to select a range
f24a1f4
feat: add tooltip field to workspace app that renders as markdown
Aug 29, 2025
14d3699
chore: update test
Aug 29, 2025
52ddebf
Merge branch 'main' into rafrdz/tooltip-support
Aug 29, 2025
2255f73
Merge branch 'main' into rafrdz/tooltip-support
Aug 29, 2025
4afab8d
chore: fix migration number
Aug 29, 2025
551a0ec
chore: fix missing tooltip field in e2e test
Sep 2, 2025
ae1dee5
chore: cleanup markdown className
Sep 2, 2025
191fa45
Merge branch 'main' into rafrdz/tooltip-support
Sep 2, 2025
c2d6191
chore: update api version
Sep 2, 2025
e3d79f1
chore: run make gen
Sep 2, 2025
bacf93b
chore: remove tooltip from agent
Sep 3, 2025
921b155
chore: add empty tooltip field for agent workspace apps to address li…
Sep 3, 2025
4c14ebd
Merge branch 'main' into rafrdz/tooltip-support
Sep 3, 2025
4755bb3
chore: remove tooltip support from subagent workspaces
Sep 3, 2025
061c7ba
chore: update wrap-anywhere tailwind class and inline tooltip check
Sep 3, 2025
0e08cc6
Merge branch 'main' into rafrdz/tooltip-support
Sep 4, 2025
cae0ec7
chore: update tooltip max length to 2048 chars
Sep 5, 2025
760b65c
Merge branch 'main' into rafrdz/tooltip-support
Sep 5, 2025
c1926bd
chore: rename migration files
Sep 5, 2025
adbd52d
chore: update migration file number
Sep 10, 2025
9b34b75
Merge branch 'main' into rafrdz/tooltip-support
Sep 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
"last_seen_at": "====[timestamp]=====",
"name": "test-daemon",
"version": "v0.0.0-devel",
"api_version": "1.9",
"api_version": "1.10",
"provisioners": [
"echo"
],
Expand Down
1 change: 1 addition & 0 deletionscoderd/agentapi/subagent.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,7 @@ func (a *SubAgentAPI) CreateSubAgent(ctx context.Context, req *agentproto.Create
Valid: app.GetGroup() != "",
String: app.GetGroup(),
},
Tooltip: "", // tooltips are not currently supported in subagent workspaces, default to empty string
})
if err != nil {
return xerrors.Errorf("insert workspace app: %w", err)
Expand Down
4 changes: 4 additions & 0 deletionscoderd/apidoc/docs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

4 changes: 4 additions & 0 deletionscoderd/apidoc/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

1 change: 1 addition & 0 deletionscoderd/database/db2sdk/db2sdk.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -582,6 +582,7 @@ func Apps(dbApps []database.WorkspaceApp, statuses []database.WorkspaceAppStatus
Group: dbApp.DisplayGroup.String,
Hidden: dbApp.Hidden,
OpenIn: codersdk.WorkspaceAppOpenIn(dbApp.OpenIn),
Tooltip: dbApp.Tooltip,
Statuses: WorkspaceAppStatuses(statuses),
})
}
Expand Down
1 change: 1 addition & 0 deletionscoderd/database/dbgen/dbgen.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -866,6 +866,7 @@ func WorkspaceApp(t testing.TB, db database.Store, orig database.WorkspaceApp) d
DisplayGroup: orig.DisplayGroup,
Hidden: orig.Hidden,
OpenIn: takeFirst(orig.OpenIn, database.WorkspaceAppOpenInSlimWindow),
Tooltip: takeFirst(orig.Tooltip, testutil.GetRandomName(t)),
})
require.NoError(t, err, "insert app")
return resource
Expand Down
5 changes: 4 additions & 1 deletioncoderd/database/dump.sql
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
ALTER TABLE workspace_apps
DROP COLUMN IF EXISTS tooltip;
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
ALTER TABLE workspace_apps
ADD COLUMN IF NOT EXISTS tooltip VARCHAR(2048) NOT NULL DEFAULT '';

COMMENT ON COLUMN workspace_apps.tooltip IS 'Markdown text that is displayed when hovering over workspace apps.';
2 changes: 2 additions & 0 deletionscoderd/database/models.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

25 changes: 17 additions & 8 deletionscoderd/database/queries.sql.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

8 changes: 5 additions & 3 deletionscoderd/database/queries/workspaceapps.sql
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,10 +31,11 @@ INSERT INTO
display_order,
hidden,
open_in,
display_group
display_group,
tooltip
)
VALUES
($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19)
($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16, $17, $18, $19, $20)
ON CONFLICT (id) DO UPDATE SET
display_name = EXCLUDED.display_name,
icon = EXCLUDED.icon,
Expand All@@ -52,7 +53,8 @@ ON CONFLICT (id) DO UPDATE SET
open_in = EXCLUDED.open_in,
display_group = EXCLUDED.display_group,
agent_id = EXCLUDED.agent_id,
slug = EXCLUDED.slug
slug = EXCLUDED.slug,
tooltip = EXCLUDED.tooltip
RETURNING *;

-- name: UpdateWorkspaceAppHealthByID :exec
Expand Down
1 change: 1 addition & 0 deletionscoderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2925,6 +2925,7 @@ func InsertWorkspaceResource(ctx context.Context, db database.Store, jobID uuid.
DisplayGroup: displayGroup,
Hidden: app.Hidden,
OpenIn: openIn,
Tooltip: app.Tooltip,
})
if err != nil {
return xerrors.Errorf("upsert app: %w", err)
Expand Down
3 changes: 3 additions & 0 deletionscodersdk/workspaceapps.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -89,6 +89,9 @@ type WorkspaceApp struct {
Group string `json:"group,omitempty"`
Hidden bool `json:"hidden"`
OpenIn WorkspaceAppOpenIn `json:"open_in"`
// Tooltip is an optional markdown supported field that is displayed
// when hovering over workspace apps in the UI.
Tooltip string `json:"tooltip,omitempty"`

// Statuses is a list of statuses for the app.
Statuses []WorkspaceAppStatus `json:"statuses"`
Expand Down
1 change: 1 addition & 0 deletionsdocs/reference/api/agents.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

8 changes: 8 additions & 0 deletionsdocs/reference/api/builds.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.

Loading
Loading

[8]ページ先頭

©2009-2025 Movatter.jp