Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add tooltip field to workspace app that renders as markdown#19651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rafrdz merged 21 commits intomainfromrafrdz/tooltip-support
Sep 10, 2025

Conversation

rafrdz
Copy link

@rafrdzrafrdz commentedAug 29, 2025•
edited
Loading

In this pull request we're adding an optionaltooltip field. Thetooltip field is a string field (with markdown support) that will be used to display tooltips on hover over app buttons in a workspace dashboard.

Tooltip screenshot

Screenshot 2025-08-29 at 4 11 56 PM

Tooltip video

tooltip-link.mov

Issue:#18431
Related provider PR:coder/terraform-provider-coder#435

Changes

  • Added migration to addtooltip column toworkspace_apps table
  • Updated queries to get/set the newtooltip column
  • Updated frontend to render tooltip as markdown (primary tool tip takes precedence over template tooltip)

Testing

  • Added storybook test forApplink markdown rendering

@rafrdzrafrdz marked this pull request as ready for reviewSeptember 2, 2025 17:20
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Things look pretty good to me on the frontend side

Copy link
Contributor

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm from the standpoint of the proto. Deferring to other reviewers for the wholistic view.

Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Everything looks good on my end!

{primaryTooltip ?(
primaryTooltip
) :app.tooltip ?(
<MarkdownclassName="text-content-secondary prose-sm font-medium wrap-anywhere">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, neat. Didn't realize that we had Tailwind's typography plugin installed. Being able to useprose classes should help a lot for markdown concerns

rafrdz reacted with rocket emoji
@matifali
Copy link
Member

matifali commentedSep 8, 2025•
edited
Loading

@rafrdz, as a follow-up, please update thedogfood/coder template so we can start dogfooding. Thanks.

rafrdz reacted with thumbs up emoji

@rafrdzrafrdz merged commite53bc24 intomainSep 10, 2025
36 checks passed
@rafrdzrafrdz deleted the rafrdz/tooltip-support branchSeptember 10, 2025 16:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

@spikecurtisspikecurtisspikecurtis approved these changes

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@rafrdzrafrdz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@rafrdz@matifali@aslilac@johnstcn@spikecurtis@Parkreiner
[8]ページ先頭
©2009-2025 Movatter.jp