NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

refactor: Display member role when user has no role#1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 4 commits intomainfrombq/add-placeholder-value-to-user-roles

Jun 2, 2022

Merged

refactor: Display member role when user has no role#1965

BrunoQuaresma merged 4 commits intomainfrombq/add-placeholder-value-to-user-roles

Jun 2, 2022

Conversation

Copy link

Collaborator

BrunoQuaresma commentedJun 1, 2022

Closes#1949

refactor: Display member role when user has no role

a25dd55

BrunoQuaresma requested a review froma team as acode owner

June 1, 2022 19:16

BrunoQuaresma self-assigned this

Jun 1, 2022

Copy link

Contributor

presleyp commentedJun 1, 2022•
edited
Loading

I have an Admin and a Member. The treatment of the Member looks good, but now (don't know if it's new) if I give the Member another role, that role shows up with a comma.

And if I take that role away again, it's blank

Copy link

CollaboratorAuthor

BrunoQuaresma commentedJun 1, 2022•
edited
Loading

@presleyp this is interesting, good catch! Is it on local our storybook?

Copy link

Contributor

presleyp commentedJun 1, 2022

@presleyp this is interesting, good catch! Is it on local our storybook?

local. I'm doingmake build now in case it was just me being out of date...

Remove fallback role from the change event

fcc7b91

Copy link

CollaboratorAuthor

BrunoQuaresma commentedJun 1, 2022

@presleyp it is fixed, but probably you have to restart the app and the database because it was sending the fallback role to the API when it should not.