- Notifications
You must be signed in to change notification settings - Fork1k
fix: fix TestExecutorAutostartSkipsWhenNoProvisionersAvailable flake, part 2#19649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedAug 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
TestExecutorAutostartSkipsWhenNoProvisionersAvailable flake, it appearsto be related to the assignment of `time.Now()` as the `LastSeenAt` timewhen creating a provisioner which can flake with the calculatedscheduled next autostart and the code to set then require.Eventually theupdated provisioner LastSeenAtinstead we should simply calculate all time values for the stale portionof the test based on the provisioners LastSeenAt value to avoid such issuesSigned-off-by: Callum Styan <callumstyan@gmail.com>
074317e todcb2f1aComparejohnstcn approved these changesSep 1, 2025
6574299 intomain 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test still flakes occasionally, seecoder/internal#954 (comment)
The cause appears to be related to the assignment of
time.Now()as theLastSeenAttime when creating a provisioner which can flake with the calculated scheduled next autostart and the code to set thenrequire.Eventuallythe updated provisioner LastSeenAt.Instead we should simply calculate all time values for the stale portion of the test based on the provisioners LastSeenAt value to avoid such issues.