Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd): fix logic for reporting prebuilt workspace duration metric#19641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ssncferreira merged 4 commits intomainfromssncferreira/fix-prebuild-creation-metric
Aug 29, 2025

Conversation

ssncferreira
Copy link
Contributor

@ssncferreirassncferreira commentedAug 29, 2025•
edited
Loading

Description

When creating a prebuilt workspace, bothflags.IsPrebuild andflags.IsFirstBuild are true. Previously, the logic rejected cases with multiple flags, socoderd_workspace_creation_duration_seconds wasn’t updated for prebuilt creations. This is the only valid scenario where two flags can be true.

Changes

  • Fix logic to updatecoderd_workspace_creation_duration_seconds metric for prebuilt workspaces.
  • Add prebuild helper functions to coderdenttest (other prebuild tests can reuse this).
  • Update workspace's provisionerdmetric tests to include this metric.

Follow-up:#19503
Related to:#19528

@ssncferreirassncferreira changed the titlefix: prebuilt workspace creation duration metricfix: fix logic for reporting prebuilt workspace duration metricAug 29, 2025
@ssncferreirassncferreiraforce-pushed thessncferreira/fix-prebuild-creation-metric branch from3cde6ae to1631ffdCompareAugust 29, 2025 13:02
@ssncferreirassncferreira changed the titlefix: fix logic for reporting prebuilt workspace duration metricfix(coderd): fix logic for reporting prebuilt workspace duration metricAug 29, 2025
@ssncferreirassncferreira marked this pull request as ready for reviewAugust 29, 2025 13:05
@ssncferreirassncferreira added the cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch labelAug 29, 2025
Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, with a couple nits.

@ssncferreirassncferreira merged commit353f5de intomainAug 29, 2025
26 checks passed
@ssncferreirassncferreira deleted the ssncferreira/fix-prebuild-creation-metric branchAugust 29, 2025 14:48
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@ssncferreirassncferreira

Labels
cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ssncferreira@dannykopping@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp