- Notifications
You must be signed in to change notification settings - Fork928
feat: flexbox updates on workspace page#1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
resolves 1910
| starting: "Starting", | ||
| delete: "Delete", | ||
| deleting: "Deleting", | ||
| cancel: "Cancel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would still say "Cancel action" here because it's the one case where the object is not the workspace. Open to thoughts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good call - this was a mistake!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Any thoughts on right-justifying the status so it's really underneath the buttons? It might not look good, just a thought. |
@presleyp I think it is a good suggestion! Since all the statuses that we have are listed as the last items, I think it would look better to have them right-aligned. |
@presleyp@BrunoQuaresma there's some extra space in this pseudo table so it ends up looking kind of funky: Also some of those tables are actual tables and some aren't. If it's okay with you folks, I will close this PR out and then spin up another ticket to properly redistribute spacing so we get a cleaner design. I agree what we have right now isn't ideal. |
@Kira-Pilot you could also ship what you had before the justification change as an incremental improvement. |
…-clarity/kira-pilot
…-clarity/kira-pilot
Should also resolve#1953: I'll add a follow-up ticket to address some of the table tweaks we've been discussing above, and also maybe handle responsive layout in a more elegant manner. |
* feat: flexbox work on workspace pageresolves 1910* fixing cancel text* chromatic fixes*resolves#1953no overflox text on smaller screens
resolves#1910
Also shortened button names as suggested by@BrunoQuaresma