Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(coderd/taskname): ensure generated name is within 32 byte limit#19612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 2 commits intomainfromdanielle/fix/taskname-length
Aug 28, 2025

Conversation

DanielleMaywood
Copy link
Contributor

The previous logic verified a generated name was valid,and then appended a suffix to it. This was flawed as it would allow a 32 character name, and then append an extra 5 characters to it.

Instead we now append the suffixand then verify it is valid.

@DanielleMaywoodDanielleMaywoodforce-pushed thedanielle/fix/taskname-length branch fromf5b3be7 to16031b2CompareAugust 28, 2025 11:31
@DanielleMaywoodDanielleMaywood changed the titlefix(coderd/taskname): ensure generated name is under 32 bytesfix(coderd/taskname): ensure generated name is with 32 bytes limitAug 28, 2025
@DanielleMaywoodDanielleMaywood changed the titlefix(coderd/taskname): ensure generated name is with 32 bytes limitfix(coderd/taskname): ensure generated name is within 32 bytes limitAug 28, 2025
@DanielleMaywoodDanielleMaywood changed the titlefix(coderd/taskname): ensure generated name is within 32 bytes limitfix(coderd/taskname): ensure generated name is within 32 byte limitAug 28, 2025
@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewAugust 28, 2025 11:40
@johnstcnjohnstcn added the cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch labelAug 28, 2025
@DanielleMaywoodDanielleMaywood merged commit347ab5b intomainAug 28, 2025
54 of 56 checks passed
@DanielleMaywoodDanielleMaywood deleted the danielle/fix/taskname-length branchAugust 28, 2025 11:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
cherry-pick/v2.26Needs to be cherry-picked to the 2.26 release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@DanielleMaywood@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp