Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor CLI agent auth tests as unit tests#19609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedAug 28, 2025•
edited
Loading

Fixescoder/internal#933

Refactors CLI tests that check the--auth flag parsing for various public clouds into a unit test that just creates the agent Client and asserts on the type.

Testing that the agent client actually authenticates correctly with these auth types is well covered by Coderd tests, so we don't need to retread that ground here, and the deleted tests were flaky on Windows.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedAug 28, 2025•
edited
Loading

@spikecurtisspikecurtis marked this pull request as ready for reviewAugust 28, 2025 11:03
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from46dfec7 to07bb100CompareAugust 28, 2025 11:05
@spikecurtisspikecurtis marked this pull request as draftAugust 28, 2025 11:15
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from07bb100 tofaa0ebfCompareAugust 28, 2025 11:20
@spikecurtisspikecurtis marked this pull request as ready for reviewAugust 28, 2025 11:20
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch fromfaa0ebf to07f5bc3CompareAugust 28, 2025 12:44
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch froma13a334 toad45ac9CompareAugust 28, 2025 12:44
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from07f5bc3 to9f9cd09CompareAugust 29, 2025 08:00
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch fromad45ac9 toce4943cCompareAugust 29, 2025 08:00
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Except for the one concern, looks fine to me 👍🏻.

@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch 2 times, most recently from608b392 toe5bf69bCompareAugust 29, 2025 08:42
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from9f9cd09 to3fbbf99CompareAugust 29, 2025 08:42
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch frome5bf69b to59667e7CompareAugust 29, 2025 12:20
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from3fbbf99 to06d66aeCompareAugust 29, 2025 12:20
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from59667e7 to54f6878CompareSeptember 2, 2025 11:18
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from06d66ae to5797ad5CompareSeptember 2, 2025 11:18
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from54f6878 to6cddf93CompareSeptember 2, 2025 11:39
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from5797ad5 to640542dCompareSeptember 2, 2025 11:39
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from6cddf93 to68c9194CompareSeptember 3, 2025 06:26
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from640542d to5f400e4CompareSeptember 3, 2025 06:26
@spikecurtisspikecurtis changed the base branch fromspike/refactor-agentsdk-instance-identity tographite-base/19609September 3, 2025 06:38
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from5f400e4 to7690732CompareSeptember 3, 2025 06:39
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/19609 tomainSeptember 3, 2025 06:39
@spikecurtisspikecurtisforce-pushed thespike/internal-933-instance-auth-cli-unit-tests branch from7690732 toeec060eCompareSeptember 3, 2025 06:39
@spikecurtisspikecurtis merged commit18945a7 intomainSep 3, 2025
27 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@spikecurtisspikecurtis deleted the spike/internal-933-instance-auth-cli-unit-tests branchSeptember 3, 2025 06:49
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flake: TestWorkspaceAgent/AWS

3 participants

@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp