- Notifications
You must be signed in to change notification settings - Fork1k
chore(coderd/database/dbauthz): refactor TestPing, TestNew, TestInTX to use dbmock#19604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // This can be removed when all tests in this package are migrated to | ||
| // dbmock as it will immediately detect recursive calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Correct me if I'm wrong, but since you have to specify the number of times a method is called indbmock this should be immediately apparent, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, I think we should linkcoder/internal#869 in the desc.
8c731a0 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Part ofcoder/internal#869