- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: bump github.com/stretchr/testify from 1.10.0 to 1.11.1#19599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: bump github.com/stretchr/testify from 1.10.0 to 1.11.1#19599
Conversation
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.10.0 to 1.11.1.- [Release notes](https://github.com/stretchr/testify/releases)- [Commits](stretchr/testify@v1.10.0...v1.11.1)---updated-dependencies:- dependency-name: github.com/stretchr/testify dependency-version: 1.11.1 dependency-type: direct:production update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>
5198127 intomainUh oh!
There was an error while loading.Please reload this page.
ethanndickson commentedSep 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The |
This PR improves the ruleguard rule for detecting `t.Fail` calls in goroutines. It picks up additional violations, of which are fixed in this PR.See self-review for details.The motivation for fixing this comes from a flake I fixed in#19599, where tests would fail from a `require` in an `Eventually`.
Closescoder/internal#961Likely the same deal as in#19599, the body of `require.Eventually` now fires immediately, when it used to fire after 250ms (the interval). Presumably, the deployment stats become ready before the vs code session count gets incremented. This was never an issue with the 250ms delay, as this flake has only cropped up after the testify version bump.We'll fix the issue by making it possible to wait for a full metrics cache refresh, i.e. removing `require.Eventually` in this test altogether.
Bumpsgithub.com/stretchr/testify from 1.10.0 to 1.11.1.
Release notes
Sourced fromgithub.com/stretchr/testify's releases.
... (truncated)
Commits
2a57335Merge pull request#1788 from brackendawson/1785-backport-1.11af8c912Backport#1786 to release/1.11b7801fbMerge pull request#1778 from stretchr/dependabot/github_actions/actions/chec...69831f3build(deps): bump actions/checkout from 4 to 5a53be35Improve captureTestingT helperaafb604mock: improve formatting of error message7218e03improve error msg929a212Merge pull request#1758 from stretchr/dolmen/suite-faster-method-filteringbc7459esuite: faster filtering of methods (-testify.m)7d37b5csuite: refactor methodFilterDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)