Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: bump github.com/stretchr/testify from 1.10.0 to 1.11.1#19599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabotdependabotbot commented on behalf ofgithubAug 28, 2025

Bumpsgithub.com/stretchr/testify from 1.10.0 to 1.11.1.

Release notes

Sourced fromgithub.com/stretchr/testify's releases.

v1.11.1

This release fixes#1785 introduced in v1.11.0 where expected argument values implementing the stringer interface (String() string) with a method which mutates their value, when passed to mock.Mock.On (m.On("Method", <expected>).Return()) or actual argument values passed to mock.Mock.Called may no longer match one another where they previously did match. The behaviour prior to v1.11.0 where the stringer is always called is restored. Future testify releases may not call the stringer method at all in this case.

What's Changed

Full Changelog:stretchr/testify@v1.11.0...v1.11.1

v1.11.0

What's Changed

Functional Changes

v1.11.0 Includes a number of performance improvements.

Fixes

Documentation, Build & CI

... (truncated)

Commits
  • 2a57335 Merge pull request#1788 from brackendawson/1785-backport-1.11
  • af8c912 Backport#1786 to release/1.11
  • b7801fb Merge pull request#1778 from stretchr/dependabot/github_actions/actions/chec...
  • 69831f3 build(deps): bump actions/checkout from 4 to 5
  • a53be35 Improve captureTestingT helper
  • aafb604 mock: improve formatting of error message
  • 7218e03 improve error msg
  • 929a212 Merge pull request#1758 from stretchr/dolmen/suite-faster-method-filtering
  • bc7459e suite: faster filtering of methods (-testify.m)
  • 7d37b5c suite: refactor methodFilter
  • Additional commits viewable incompare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting@dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.10.0 to 1.11.1.- [Release notes](https://github.com/stretchr/testify/releases)- [Commits](stretchr/testify@v1.10.0...v1.11.1)---updated-dependencies:- dependency-name: github.com/stretchr/testify  dependency-version: 1.11.1  dependency-type: direct:production  update-type: version-update:semver-minor...Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotbot added dependenciesPull requests that update a dependency file goPull requests that update go code labelsAug 28, 2025
@github-actionsgithub-actionsbotenabled auto-merge (squash)August 28, 2025 01:12
@github-actionsgithub-actionsbot merged commit5198127 intomainSep 2, 2025
26 checks passed
@github-actionsgithub-actionsbot deleted the dependabot/go_modules/github.com/stretchr/testify-1.11.1 branchSeptember 2, 2025 03:12
@ethanndickson
Copy link
Member

ethanndickson commentedSep 2, 2025
edited
Loading

TheTestLabelsAggregation flake I fixed in the last commit was caused by a change torequire.Eventually - it now runs the body immediately, instead of waiting for the first tick. However, if arequire.Eventually body has arequire.* assertion that fails, therequire.Eventually body doesn't run again, causing the test failure. I fixed it by just having theEventually body return false if the metrics weren't yet equal, which is the intention of the test, fwict, and that fixed the flake.

ethanndickson added a commit that referenced this pull requestSep 4, 2025
This PR improves the ruleguard rule for detecting `t.Fail` calls in goroutines. It picks up additional violations, of which are fixed in this PR.See self-review for details.The motivation for fixing this comes from a flake I fixed in#19599, where tests would fail from a `require` in an `Eventually`.
ethanndickson added a commit that referenced this pull requestSep 8, 2025
Closescoder/internal#961Likely the same deal as in#19599, the body of `require.Eventually` now fires immediately, when it used to fire after 250ms (the interval). Presumably, the deployment stats become ready before the vs code session count gets incremented. This was never an issue with the 250ms delay, as this flake has only cropped up after the testify version bump.We'll fix the issue by making it possible to wait for a full metrics cache refresh, i.e. removing `require.Eventually` in this test altogether.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

Assignees
No one assigned
Labels
dependenciesPull requests that update a dependency filegoPull requests that update go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp