Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add coder_workspace_write_file MCP tool#19591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 5 commits intomainfromasher/mcp-file-write
Sep 11, 2025

Conversation

code-asher
Copy link
Member

A follow up to the read tool added in#19562

@code-ashercode-asherforce-pushed theasher/mcp-file-write branch 2 times, most recently from49ea415 to15720afCompareAugust 27, 2025 22:37
@code-ashercode-asherforce-pushed theasher/mcp-file-read branch 3 times, most recently from2972507 toa042936CompareAugust 28, 2025 19:53
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelSep 6, 2025
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelSep 9, 2025
Base automatically changed fromasher/mcp-file-read tomainSeptember 9, 2025 23:12
@code-ashercode-asherforce-pushed theasher/mcp-file-write branch 3 times, most recently from8c658eb to13e42f0CompareSeptember 9, 2025 23:25
Copy link
Member

@ThomasK33ThomasK33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor nits and suggestions, nothing that should block a merge though.

Comment on lines +1466 to +1468
"content":map[string]any{
"type":"string",
"description":"The base64-encoded bytes to write to the file.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we maybe want to limit the amount of file writing? Reads are 1MB, I think, so it might make sense to introduce a restriction here, too.

Copy link
MemberAuthor

@code-ashercode-asherSep 11, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had that thought too but I am not sure how to make that restriction. The max is useful to make sure we are not going to run out of memory, but by the time we are here, anything in memory is already in memory and we might as well write it out since we have it.

I think instead of the tool handler, the restriction would need to be in the MCP library at the point where it reads in the data (and maybe it already has limits, I have not tested). Not sure if this is configurable though, or if we can hook in somewhere to enforce the restriction.

Copy link
MemberAuthor

@code-ashercode-asherSep 11, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm maybeWithHooks will let me do it. Ohhh wait there is aMaxLength that I could pass through, which is probably what you were already thinking of 😅 Gonna implement this. I will need an offset as well, or an append boolean.

edit: er wait does not seem the server is enforcing the max length property...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, gotcha. In that case, I think we're good here.

code-asher reacted with thumbs up emoji
Comment on lines +1466 to +1468
"content":map[string]any{
"type":"string",
"description":"The base64-encoded bytes to write to the file.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, gotcha. In that case, I think we're good here.

code-asher reacted with thumbs up emoji
@code-ashercode-asher merged commitd5a02d5 intomainSep 11, 2025
31 checks passed
@code-ashercode-asher deleted the asher/mcp-file-write branchSeptember 11, 2025 20:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ThomasK33ThomasK33ThomasK33 approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@code-asher@ThomasK33

[8]ページ先頭

©2009-2025 Movatter.jp