- Notifications
You must be signed in to change notification settings - Fork1k
fix: don't show prebuild workspaces as tasks#19572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some small nits, but this looks like a good change to me!
site/src/api/api.ts Outdated
| }).then((res)=> | ||
| res.workspaces.filter((workspace)=>!workspace.is_prebuild), | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: I know this is valid, but I feel like if we're going to be usingawait syntax, we shouldn't be using promise-chaining in the same function scope, just for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also, could we add a comment giving some extra context for why we're filtering pre-builds out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the API should be ready to be used by the FE soon
So we will be fixing this later on the API side? If so, I think this change makes sense temporarily. 👍
abc946c intomainUh oh!
There was an error while loading.Please reload this page.
Fixes#19570
Before:
After:
Things to notice: