Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: refactor instance identity to be a SessionTokenProvider#19566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedAug 27, 2025•
edited
Loading

Refactors Agent instance identity to be a SessionTokenProvider.

Refactors the CLI to create Agent clients via a centralized function, rather than add-hoc via individual command handlers and their flags.

This allows commands besidescoder agent, but which still use the agent identity, to support instance identity authentication.

Fixes#19111 by unifying all API requests to go thru the SessionTokenProvider for auth credentials.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedAug 27, 2025•
edited
Loading

@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from1b453cd to421347bCompareAugust 28, 2025 06:25
@spikecurtisspikecurtisforce-pushed thespike/refactor-sdk-session-token-provider branch from6f7bb8d toad7200fCompareAugust 28, 2025 06:25
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from421347b to7b1affeCompareAugust 28, 2025 06:40
@spikecurtisspikecurtisforce-pushed thespike/refactor-sdk-session-token-provider branch 2 times, most recently from7789799 tod9ee61fCompareAugust 28, 2025 09:36
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from7b1affe toa13a334CompareAugust 28, 2025 09:36
@spikecurtisspikecurtis marked this pull request as ready for reviewAugust 28, 2025 10:56
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch 2 times, most recently fromad45ac9 toce4943cCompareAugust 29, 2025 08:00
@spikecurtisspikecurtisforce-pushed thespike/refactor-sdk-session-token-provider branch from53e1b76 to7ea81d2CompareAugust 29, 2025 08:00
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For the most part, this looks like a good and a useful refactor 👍🏻.

I'd like to see something done about the root command logic/flag, however (see comment). Other than that just minor suggestions.

@@ -0,0 +1,97 @@
package agentsdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggestion (optional): Consider moving into sub-package, assuming there aren't any blocking dependencies to this package that would cause a circular import.

@spikecurtisspikecurtis changed the base branch fromspike/refactor-sdk-session-token-provider tographite-base/19566August 29, 2025 08:41
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch fromce4943c to608b392CompareAugust 29, 2025 08:41
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/19566 tomainAugust 29, 2025 08:42
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch 3 times, most recently from59667e7 to54f6878CompareSeptember 2, 2025 11:18
@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from54f6878 to6cddf93CompareSeptember 2, 2025 11:39
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This turned out nice, and love the explicit flag docs this gives us, thanks for implementing! Two minor suggestions but nothing blocking:shipit:

// to check if the command was invoked.
ifgitauth.CheckCommand(i.Args,i.Environ.ToOS()) {
returnr.gitAskpass().Handler(i)
returngitAskpass(hiddenAgentAuth).Handler(i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice solution 👍🏻

@spikecurtisspikecurtisforce-pushed thespike/refactor-agentsdk-instance-identity branch from6cddf93 to68c9194CompareSeptember 3, 2025 06:26
@spikecurtisspikecurtis merged commit1354d84 intomainSep 3, 2025
27 of 29 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@spikecurtisspikecurtis deleted the spike/refactor-agentsdk-instance-identity branchSeptember 3, 2025 06:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Prebuilds agent reinitialization doesn't work if cloud identity is used
2 participants
@spikecurtis@mafredri
[8]ページ先頭
©2009-2025 Movatter.jp