- Notifications
You must be signed in to change notification settings - Fork1k
feat: add coder_workspace_read_file MCP tool#19562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7bda4fd to2828b76Compare2828b76 toaae3033CompareThis will be used in multiple tools.
aae3033 to2972507Compare2972507 toa042936CompareUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
I prefer buffering in the toolsdk instead of the workspacesdk, but I don't want to block on it.
Uh oh!
There was an error while loading.Please reload this page.
codersdk/workspacesdk/agentconn.go Outdated
| // Ideally we could stream this all the way back, but it looks like the MCP | ||
| // interfaces only allow returning full responses which means the whole thing | ||
| // has to be read into memory. So, add a maximum to compensate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We might want to implement the buffering in the MCP server/toolsdk and keep this part as a streaming response. Functionality-wise, this should remain the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
100% agree. Will change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let me know if you want another review; otherwise, it's good to merge with that change from my POV.
1d4cd78 tof903423Compare4bf63b4 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Follows similarly to the bash tool (and some code to connect to an agent was extracted from it).
There are two main parts: a new agent endpoint, and then a new MCP tool that consumes that endpoint.