I suspect this is the root cause

If the build has no AI task, it means that the provisioner job is in progress
and we don't know if it has an AI task yet. In this case, we optimistically
assume that it has an AI task if the AI Prompt parameter is not empty.
lets the AI Task frontend spawn a task and see it immediately after instead of
having to wait for the build to complete.

https://github.com/coder/coder/blob/8083d9d5c87fbb7d7d8f018706a8d0769480378a/coderd/database/queries/workspaces.sql#L357C1-L372C46

So we're potentially returning workspaces that do not yet havehas_ai_task set

I suspect this is the root cause

If the build has no AI task, it means that the provisioner job is in progress
and we don't know if it has an AI task yet. In this case, we optimistically
assume that it has an AI task if the AI Prompt parameter is not empty.
lets the AI Task frontend spawn a task and see it immediately after instead of
having to wait for the build to complete.

8083d9d/coderd/database/queries/workspaces.sql#L357C1-L372C46

So we're potentially returning workspaces that do not yet havehas_ai_task set

@DanielleMaywood that does indeed look like it would be the culprit. We definitely need to improve how tasks are detected so there can't be any flip-flopping between states.

We definitely need to improve how tasks are detected so there can't be any flip-flopping between states.

Honestly I think the 'correct' fix here is to have tasks defined separately to workspaces.

Honestly I think the 'correct' fix here is to have tasks defined separately to workspaces.

I definitely agree. I don't think that excludes an interim fix, though. For now we could relax the "ai task" constraint to match that of the query.

I.e. intasksFromWorkspaces remove:

for _, ws := range apiWorkspaces {if ws.LatestBuild.HasAITask == nil || !*ws.LatestBuild.HasAITask {return nil, xerrors.Errorf("workspace %s is not an AI task workspace", ws.ID)}}

Honestly I think the 'correct' fix here is to have tasks defined separately to workspaces.

I definitely agree. I don't think that excludes an interim fix, though. For now we could relax the "ai task" constraint to match that of the query.

I.e. intasksFromWorkspaces remove:

for _, ws := range apiWorkspaces {if ws.LatestBuild.HasAITask == nil || !*ws.LatestBuild.HasAITask {return nil, xerrors.Errorf("workspace %s is not an AI task workspace", ws.ID)}}

Sounds good to me, it appears to work locally also:

cdr-mbp-jmqxfj0746:coder cian$ ./scripts/coder-dev.sh exp tasks create --input hello tasks && ./scripts/coder-dev.sh exp tasks listThe task task-crazy-williamson-34b8 has been created at Aug 27 12:19:37!ID                                    NAME                        STATUS    STATE  STATE CHANGED  MESSAGE5bdfa8ee-55fd-4d9c-bd63-212176d6a5b3  task-crazy-williamson-34b8  starting  <nil>                 <nil>69a7e749-37ea-48c7-88a4-6ed78e737459  task-youthful-pare-6c73     running   <nil>                 <nil>