- Notifications
You must be signed in to change notification settings - Fork1k
feat(enterprise/coderd): allow system users to be added to groups#19518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
20 commits Select commitHold shift + click to select a range
6b3a731 Allow users to view and modify group membership for the prebuilds sys…
SasSwart4b63826 Fix Tests
SasSwart90b9078 Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwartaf7c7cd fix tests
SasSwart1cd68e3 create a prebuilds group in every org that needs it
SasSwart4c0c4d4 Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwart93c46e9 add lint rule
SasSwartb3728d3 add quotas tests to verify prebuilds behaviour
SasSwartefdfe9f fix unit test context
SasSwart8204ec2 revert broken query changes
SasSwart92760d1 make gen
SasSwart471c29e Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwartf9a5fbb Hide system users
SasSwart959c89e remove prototype snippet
SasSwart1da8e34 refactor prebuilds reconciliation test
SasSwartcf6ee1c check whether a prebuilds group exists before adding it
SasSwartb685245 make fmt
SasSwarte828366 Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-gr…
SasSwartadf7657 fix: rename constant to match validation
SasSwart820cfd6 Update enterprise/coderd/prebuilds/membership_test.go
SasSwartFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix: rename constant to match validation
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitadf7657fcb3c14d75c6a0d30af436fa6060e99fb
There are no files selected for viewing
2 changes: 1 addition & 1 deletionenterprise/coderd/prebuilds/membership.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -13,7 +13,7 @@ import ( | ||
| ) | ||
| const ( | ||
| PrebuiltWorkspacesGroupName = "coderprebuiltworkspaces" | ||
ssncferreira marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| PrebuiltWorkspacesGroupDisplayName = "Prebuilt Workspaces" | ||
| ) | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.