- Notifications
You must be signed in to change notification settings - Fork1k
feat(enterprise/coderd): allow system users to be added to groups#19518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tem user so that they can configure quotas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Overall LGTM, just a question about the Quota Allowance of the prebuilds group as 0.
| DisplayName:PrebuiltWorkspacesGroupDisplayName, | ||
| OrganizationID:preset.OrganizationID, | ||
| AvatarURL:"", | ||
| QuotaAllowance:0,// Default quota of 0, users should set this based on their needs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Correct me if I'm wrong, but does this mean that once this change is rolled out, no more prebuilt workspaces will be able to be provisioneduntil the Quota Allowance is changed? Or is the prebuilds user still part of theEveryone group?
Just asking because, in case there is a need for user action, we might need to consider this a breaking change and explicitly document the steps to set this allowance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the prebuilds user is still a member of the everyone group, so this shouldn't be too much of a breaking change.
ssncferreiraAug 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, thanks for the clarification!
nit(non-blocking): It might be helpful to also add this info to the documentation, that the prebuilds user is a member of theEveryone group (which also has a quota allowance). Maybe also include a section explaining that if the quota is exceeded, the workspace build will fail and the prebuilds group quota allowance should be increased.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Susana Ferreira <susana@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, let's try it 🤞
Just a small non-blocking nit for documentation
| DisplayName:PrebuiltWorkspacesGroupDisplayName, | ||
| OrganizationID:preset.OrganizationID, | ||
| AvatarURL:"", | ||
| QuotaAllowance:0,// Default quota of 0, users should set this based on their needs |
ssncferreiraAug 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok, thanks for the clarification!
nit(non-blocking): It might be helpful to also add this info to the documentation, that the prebuilds user is a member of theEveryone group (which also has a quota allowance). Maybe also include a section explaining that if the quota is exceeded, the workspace build will fail and the prebuilds group quota allowance should be increased.
4e9ee80 intomainUh oh!
There was an error while loading.Please reload this page.
closes#18274
This pull request makes system users visible in various group related queries so that they can be added to and removed from groups. This allows system user quotas to be configured. System users are still ignored in certain queries, such as when license seat consumption is determined.
This pull request further ensures the existence of a "coder_prebuilt_workspaces" group in any organization that needs prebuilt workspaces