Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Improve empty states for workspaces and templates#1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 15 commits intomainfrombq/improve-empty-state
Jun 1, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Comment on lines +9 to +10
className?:string
buttonClassName?:string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thought: One thing to consider here is mimicking MUIs API.

These use aclasses object, so it would look like this:

<CodeExample classes={{ root: ..., button: ..., }} />

I'm adding this as athought because it's not required to do anything now, just wanted to pose the question.

Might make sense as a FE V topic.

BrunoQuaresma reacted with thumbs up emoji
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with you, but I see some components are already using the patternelementClassName so I just keep it for consistency but IMO, we should try to use theclasses prop to keep parity with MUIs API.

@BrunoQuaresmaBrunoQuaresmaenabled auto-merge (squash)June 1, 2022 16:54
@BrunoQuaresmaBrunoQuaresma merged commitb85de3e intomainJun 1, 2022
@BrunoQuaresmaBrunoQuaresma deleted the bq/improve-empty-state branchJune 1, 2022 17:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AbhineetJainAbhineetJainAbhineetJain left review comments

@greyscaledgreyscaledgreyscaled left review comments

@khorne3khorne3khorne3 left review comments

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display informative message when there is no workspaces or templates
5 participants
@BrunoQuaresma@AbhineetJain@greyscaled@khorne3@Kira-Pilot

[8]ページ先頭

©2009-2025 Movatter.jp