- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(cli): add coder exp tasks list#19496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
4310e5d tob269f85Comparec1a203d toea4b615Compare5d1bd5b to5d0a8ccCompare| r.Route("/{user}",func(r chi.Router) { | ||
| r.Use(httpmw.ExtractOrganizationMembersParam(options.Database,api.HTTPAuth.Authorize)) | ||
| r.Get("/",api.tasksList) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Review: This path was not conducive to listing other members tasks (e.g. owner).
Note: I don't think it is, but would appreciate validation if the above httpmw is needed for the list endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't seehttpmw.OrganizationMemberParam in use incoderd/aitasks.go so I think you're good 👍
5d0a8cc to5665d32Compare5665d32 to9a5f639Compare
johnstcn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
cli/exp_tasklist.go Outdated
| typetaskListRowstruct { | ||
| Task codersdk.Task`table:"t,recursive_inline"` | ||
| StateChangedstring`table:"state changed"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: suggest namingStateChangedAt or similar so that the semantics are clearer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since this is relative, how aboutStateChangeAgo?
836324e intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixescoder/internal#892
Fixescoder/internal#896
Example output: